-
Notifications
You must be signed in to change notification settings - Fork 837
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[EuiDataGrid] Handle exposed ref APIs potentially pointing to invalid, off-page, or out of view cells #5572
Merged
cee-chen
merged 10 commits into
elastic:feat/datagrid/5310
from
cee-chen:datagrid/ref/row-index
Feb 1, 2022
Merged
[EuiDataGrid] Handle exposed ref APIs potentially pointing to invalid, off-page, or out of view cells #5572
cee-chen
merged 10 commits into
elastic:feat/datagrid/5310
from
cee-chen:datagrid/ref/row-index
Feb 1, 2022
Commits on Jan 27, 2022
-
Enable sorting + targeting row indices outside of the current page
- to test handling the exposed APIs when dealing with sorted/paginated data
Configuration menu - View commit details
-
Copy full SHA for 2874148 - Browse repository at this point
Copy the full SHA 2874148View commit details -
Switch data grid example to Typescript
- to test type issues during consumer usage + @ts-ignore faker complaints
Configuration menu - View commit details
-
Copy full SHA for eaeaba2 - Browse repository at this point
Copy the full SHA eaeaba2View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7786fcc - Browse repository at this point
Copy the full SHA 7786fccView commit details -
Configuration menu - View commit details
-
Copy full SHA for 4a80624 - Browse repository at this point
Copy the full SHA 4a80624View commit details -
[setup] Move imperative handler setup to its own util file
- this will let us set up ref-specific helpers & add more comment context without bloating the main file
Configuration menu - View commit details
-
Copy full SHA for 540de15 - Browse repository at this point
Copy the full SHA 540de15View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9477d1f - Browse repository at this point
Copy the full SHA 9477d1fView commit details -
- Converts the `rowIndex` from the consumer to a `visibleRowIndex` that our internal state can use - Account for sorted grid by finding the inversed index of the `sortedRowMap` - To make this easier, I converted soredRowMap to an array (since it's already only uses numbers for both keys and values), since arrays have a handy .findIndex method - Handles automatically paginating the grid if the targeted cell is on a different page
Configuration menu - View commit details
-
Copy full SHA for 74a833f - Browse repository at this point
Copy the full SHA 74a833fView commit details -
Configuration menu - View commit details
-
Copy full SHA for ba29a97 - Browse repository at this point
Copy the full SHA ba29a97View commit details -
Configuration menu - View commit details
-
Copy full SHA for 56465f6 - Browse repository at this point
Copy the full SHA 56465f6View commit details
Commits on Feb 1, 2022
-
[PR feedback] Rename fns to indicate multiple concerns
- having a side effect in a getter feels bad, so change that to a `find` - rename use hook to indicate sorting and pagination concerns
Configuration menu - View commit details
-
Copy full SHA for 55a4ba6 - Browse repository at this point
Copy the full SHA 55a4ba6View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.