Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TypeScript] Return type for resolveWidthAsStyle #5615

Merged
merged 2 commits into from
Feb 10, 2022
Merged

[TypeScript] Return type for resolveWidthAsStyle #5615

merged 2 commits into from
Feb 10, 2022

Conversation

thompsongl
Copy link
Contributor

@thompsongl thompsongl commented Feb 9, 2022 •
edited
Loading

Summary

Adds an explicit return type of CSSProperties to resolveWidthAsStyle (table util) to avoid a verbose inferred type resulting in hundreds of cssType imports in the shape of:

WebkitTransform?: import("csstype").Property.Transform | undefined;

Previously, the verbosity was present, but did not use an import:

WebkitTransform?: string | undefined;

This change will eliminate ~700s line from eui.d.ts

Checklist

  • Checked for breaking changes and labeled appropriately
  • A changelog entry exists and is marked appropriately

@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_5615/

@thompsongl thompsongl marked this pull request as ready for review February 9, 2022 21:09
chandlerprall
chandlerprall approved these changes Feb 9, 2022
View reviewed changes
Copy link
Contributor

@chandlerprall chandlerprall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_5615/

@thompsongl thompsongl merged commit db29986 into elastic:main Feb 10, 2022
@breehall breehall mentioned this pull request Feb 10, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chandlerprall chandlerprall chandlerprall approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@thompsongl @kibanamachine @chandlerprall