[EuiDataGrid] Fix open cell popovers causing auto height rows to bug out + misc cleanup #5622
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `flex` display on the parent `.euiDataGridRowCell` is unnecessary, and what's causing this bug
- it's being overridden by react-window's absolute positioning in any case
…the popover anchor wrapper - as far as I can tell, it's not doing anything
- the width properties aren't doing anything, so remove them - the height property is doing something but is superfluous with the inline height: 100%, so remove the inline style - add an overflow hidden to preserve overflowing content being correctly cropped by the cell padding when the popover is open (the EuiWrappingPopover adds extra div wrappers)
- can be conditional JSX instead of repeating EuiDataGridCellContent again
2 tasks
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_5622/ |
|
Still going through examples, but found one issue with the focus ring being cut off on EuiButtons in a cell on https://eui.elastic.co/pr_5622/#/tabular-content/data-grid-focus Before
After
|
|
This cutoff was already occurring for me on latest main on Firefox. Is it not for you? edit: interesting, looks like it was occurring on FF but not on webkit. I wonder why. Investigating |
|
Second affected example, looks like the footer row no longer spans out of the viewport https://eui.elastic.co/pr_5622/#/tabular-content/data-grid-styling-and-control Beforefooter-before.movAfterfooter-after.mov |
+ was already in place in main since 40.0.0
- footer cells aren't virtualized and don't have absolute positioning inline
+ move footer-specific CSS that virtualized data grid cells don't need to the footer row file
chandlerprall
approved these changes
Feb 10, 2022
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_5622/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This is an CSS-only alternative to #5618, and should (in theory) be a better approach with less side effects or edge cases on consuming applications. This also contains a lot more CSS cleanup.
Before
After
How does the fix work?
The main fix is 6b587ad which primarily just removes
display: flexon.euiDataGridCell. Thanks to Chandler for pointing me in the right direction on what was happening:Flexbox was the culprit for this, and was totally unnecessary on the
.EuiDataGridCell- removing it did not affect any cell layout positioning as child wrappers were already taking care of that.Why is the removed CSS no longer needed?
The flex CSS and width CSS is likely no longer necessary for the following reasons
QA
Checklist
- [ ] Props have proper autodocs and playground toggles- [ ] Added documentation- [ ] Checked Code Sandbox works for any docs examples- [ ] Added or updated jest and cypress tests- [ ] Checked for breaking changes and labeled appropriately