[EuiBreadcrumb] Extend HTMLElement and EuiLink.color & [EuiPageHeader] Adding breadcrumbs as an option
#5634
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_5634/ |
cchaos
changed the title
breadcrumbs as an optionHTMLElement and EuiLink.color & [EuiPageHeader] Adding breadcrumbs as an option
cchaos
commented
Feb 15, 2022
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_5634/ |
miukimiu
approved these changes
Feb 16, 2022
Comment on lines
5
to
34
| const breadcrumbs: EuiBreadcrumb[] = [ | ||
| { | ||
| text: 'Animals', | ||
| href: '#', | ||
| color: 'primary', | ||
| onClick: (e: { preventDefault: () => void }) => { | ||
| e.preventDefault(); | ||
| }, | ||
| }, | ||
| { | ||
| text: 'Reptiles', | ||
| color: 'primary', | ||
| }, | ||
| { | ||
| text: ( | ||
| <> | ||
| <EuiIcon type="alert" size="s" /> Boa constrictor | ||
| </> | ||
| ), | ||
| title: 'Boa constrictor has an error', | ||
| href: '#', | ||
| color: 'danger', | ||
| onClick: (e: { preventDefault: () => void }) => { | ||
| e.preventDefault(); | ||
| }, | ||
| }, | ||
| { | ||
| text: 'Edit', | ||
| }, | ||
| ]; |
There was a problem hiding this comment.
Maybe you can provide a better real-world example.
There was a problem hiding this comment.
Is animal classification not real world? 🤣
Merged
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_5634/ |
thompsongl
reviewed
Feb 17, 2022
Co-authored-by: Greg Thompson <thompson.glowe@gmail.com>
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_5634/ |
1 similar comment
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_5634/ |
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_5634/ |
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_5634/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
EuiBreadcrumbs
Each EuiBreadcrumb now extends a basic
HTMLElementin order to customize thetitlefor indicating things like alerts, as well ascolorfrom EuiLink (but only if rendering as an EuiLink otherwise it stays subdued).EuiPageHeader
I've been seeing more and more patterns of folks introducing breadcrumbs, or at the very least a "Return" link, to the top of the page header. This PR adds this ability directly into
EuiPageHeadervia a newbreadcrumbsprop.Checklist
[ ] Checked for breaking changes and labeled appropriately