Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[EuiDataGrid][EuiSelectable] Add data-test attributes for more explicit E2E testing #5643

Merged
merged 4 commits into from
Feb 16, 2022
Merged

[EuiDataGrid][EuiSelectable] Add data-test attributes for more explicit E2E testing #5643

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
6f7e3e4
Add `data-test-subj` to expand cell button
cee-chen Feb 16, 2022
4d55979
Add `data-test-selected` to EuiSelectableListItem
cee-chen Feb 16, 2022
ed9015f
Add changelog entry
cee-chen Feb 16, 2022
5beb576
[PR feedback] Changelog
constancecchen Feb 16, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
## [`main`](https://github.com/elastic/eui/tree/main)

No public interface changes since `48.1.0`.
- Added two new `data-test` attributes to `EuiDataGrid` and `EuiSelectable` for more explicit E2E testing ([#5643](https://github.com/elastic/eui/pull/5643))
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this go under a **Bug fixes** header if we want this to be a patch release?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's ok to just make it a patch during release. They're test-only changes.

cee-chen marked this conversation as resolved.
Show resolved Hide resolved

## [`48.1.0`](https://github.com/elastic/eui/tree/v48.1.0)

Expand Down
1 change: 1 addition & 0 deletions src/components/datagrid/body/data_grid_cell_actions.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,7 @@ describe('EuiDataGridCellActions', () => {
aria-hidden={true}
className="euiDataGridRowCell__actionButtonIcon"
color="primary"
data-test-subj="euiDataGridCellExpandButton"
display="fill"
iconSize="s"
iconType="expandMini"
Expand Down
1 change: 1 addition & 0 deletions src/components/datagrid/body/data_grid_cell_actions.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,7 @@ export const EuiDataGridCellActions = ({
<EuiButtonIcon
display="fill"
className="euiDataGridRowCell__actionButtonIcon"
data-test-subj="euiDataGridCellExpandButton"
color="primary"
iconSize="s"
iconType="expandMini"
Expand Down
6 changes: 6 additions & 0 deletions src/components/selectable/__snapshots__/selectable.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,7 @@ exports[`EuiSelectable custom options with data 1`] = `
aria-selected="false"
aria-setsize="3"
class="euiSelectableListItem euiSelectableListItem--paddingSmall"
data-test-selected="false"
id="generated-id_option-0"
role="option"
style="position:absolute;left:0;top:0;height:32px;width:100%"
Expand Down Expand Up @@ -57,6 +58,7 @@ exports[`EuiSelectable custom options with data 1`] = `
aria-selected="false"
aria-setsize="3"
class="euiSelectableListItem euiSelectableListItem--paddingSmall"
data-test-selected="false"
id="generated-id_option-1"
role="option"
style="position:absolute;left:0;top:32px;height:32px;width:100%"
Expand Down Expand Up @@ -84,6 +86,7 @@ exports[`EuiSelectable custom options with data 1`] = `
aria-selected="false"
aria-setsize="3"
class="euiSelectableListItem euiSelectableListItem--paddingSmall"
data-test-selected="false"
id="generated-id_option-2"
role="option"
style="position:absolute;left:0;top:64px;height:32px;width:100%"
Expand Down Expand Up @@ -168,6 +171,7 @@ exports[`EuiSelectable errorMessage prop does not render the message when not de
aria-selected="false"
aria-setsize="3"
class="euiSelectableListItem euiSelectableListItem--paddingSmall"
data-test-selected="false"
data-test-subj="titanOption"
id="generated-id_option-0"
role="option"
Expand Down Expand Up @@ -196,6 +200,7 @@ exports[`EuiSelectable errorMessage prop does not render the message when not de
aria-selected="false"
aria-setsize="3"
class="euiSelectableListItem euiSelectableListItem--paddingSmall"
data-test-selected="false"
id="generated-id_option-1"
role="option"
style="position:absolute;left:0;top:32px;height:32px;width:100%"
Expand Down Expand Up @@ -223,6 +228,7 @@ exports[`EuiSelectable errorMessage prop does not render the message when not de
aria-selected="false"
aria-setsize="3"
class="euiSelectableListItem euiSelectableListItem--paddingSmall"
data-test-selected="false"
id="generated-id_option-2"
role="option"
style="position:absolute;left:0;top:64px;height:32px;width:100%"
Expand Down
Loading