[EuiHorizontalRule] convert horizontal rule to emotion #5815
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
49 tasks
cee-chen
reviewed
Apr 19, 2022
cee-chen
reviewed
Apr 19, 2022
| component | ||
| .find('EuiButtonIcon.euiMarkdownEditorFooter__helpButton') | ||
| .simulate('click'); | ||
|
|
||
| expect(component).toMatchSnapshot(); | ||
| expect(component.find('EuiModal').length).toBe(1); |
cee-chen
reviewed
Apr 19, 2022
cee-chen
reviewed
Apr 19, 2022
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_5815/ |
cee-chen
reviewed
Apr 19, 2022
Co-authored-by: Constance <constancecchen@users.noreply.github.com>
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_5815/ |
10 tasks
cchaos
reviewed
Apr 20, 2022
Co-authored-by: Caroline Horn <549577+cchaos@users.noreply.github.com>
Co-authored-by: Caroline Horn <549577+cchaos@users.noreply.github.com>
Co-authored-by: Caroline Horn <549577+cchaos@users.noreply.github.com>
Co-authored-by: Caroline Horn <549577+cchaos@users.noreply.github.com>
cchaos
approved these changes
Apr 21, 2022
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_5815/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Converts EuiHorizontalRule to Emotion. diff'd full-page screen shots with no difference.
This required updating a markdown editor test to check for an element existence instead of taking a full snapshot.
Things to look out for when moving styles
- [ ] Anything in the backlog that could be a quick fix for that component?- [ ] Convert component-specific Sass vars to exported JS versions-inlineand-block(Logical properties)- [ ] Usegapproperty to add margin between items if using flex- [ ] Can any still existing.jsfiles be converted to TS?QA
className,css, andstyleprops work properly when passed by the consumerChecklist
- [ ] Props have proper autodocs and playground toggles- [ ] Added documentation- [ ] Checked Code Sandbox works for any docs examples- [ ] Added or updated jest and cypress tests- [ ] Checked for accessibility including keyboard-only and screenreader modes- [ ] Updated the Figma library counterpart