Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Emotion] Convert the rest of the Loading components #5845

Merged
merged 19 commits into from
Apr 28, 2022
Merged

[Emotion] Convert the rest of the Loading components #5845

Show file tree
Hide file tree
Changes from 14 commits
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
f6d4e10
[Emotion] Converted EuiLoadingContent
Apr 20, 2022
0e7ee5c
[Emotion] Converted EuiLoadingLogo
Apr 20, 2022
39b12d8
[Emotion] Converted EuiLoadingElastic
Apr 20, 2022
b750d1d
Added jest tests for EuiLoadingElastic
Apr 20, 2022
bed70dc
[Emotion] Converted EuiLoadingSpinner
Apr 20, 2022
b64092a
more snaps
Apr 20, 2022
90f0978
Merge remote-tracking branch origin/main into css-in-js-convert/loadi…
Apr 25, 2022
b61ab12
Updated to the const verson of `euiCanAnimate`
Apr 25, 2022
803d0cf
Added re-usable `useLoadingAriaLabel` single string and role attributes
Apr 25, 2022
8a412d9
Merge remote-tracking branch 'origin/main' into css-in-js-convert/loa…
Apr 25, 2022
4bcf099
Trying TS pattern
Apr 25, 2022
d620c81
Fixed some animated logo affordance and cant animate styles
Apr 26, 2022
9544c4b
Merge remote-tracking branch 'origin/main' into css-in-js-convert/loa…
Apr 26, 2022
de875f6
Cleanup & CL
Apr 26, 2022
531d25c
Merge remote-tracking branch 'origin/main' into css-in-js-convert/loa…
Apr 27, 2022
7f304c2
Fix logo animation
Apr 27, 2022
740df0c
Fix TS type maps
Apr 27, 2022
7619322
Cleanup
Apr 27, 2022
be66bdc
[EuiLoadingContent] Fix animation in Safari, but cant fix border-radius
Apr 27, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion src-docs/src/views/loading/loading_example.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,10 @@ export const LoadingExample = {
),
props: { EuiLoadingLogo },
demo: <LoadingLogo />,
snippet: '<EuiLoadingLogo size="m" />',
snippet: [
'<EuiLoadingLogo size="m" />',
'<EuiLoadingLogo logo="logoSecurity" />',
],
playground: loadingLogoConfig,
},
{
Expand Down
9 changes: 0 additions & 9 deletions src-docs/src/views/theme/_json/eui_theme_dark.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -229,15 +229,6 @@
"medium": "14px",
"large": "22px"
},
"euiGradientStartStop": "#2e3039",
"euiGradientMiddle": "#282a31",
"euiLoadingSpinnerSizes": {
"small": "12px",
"medium": "16px",
"large": "24px",
"xLarge": "32px",
"xxLarge": "40px"
},
"euiMarkdownEditorMinHeight": "150px",
"euiPopoverArrowSize": "12px",
"euiPopoverTranslateDistance": "8px",
Expand Down
9 changes: 0 additions & 9 deletions src-docs/src/views/theme/_json/eui_theme_light.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -229,15 +229,6 @@
"medium": "14px",
"large": "22px"
},
"euiGradientStartStop": "#f0f2f6",
"euiGradientMiddle": "#f6f8fa",
"euiLoadingSpinnerSizes": {
"small": "12px",
"medium": "16px",
"large": "24px",
"xLarge": "32px",
"xxLarge": "40px"
},
"euiMarkdownEditorMinHeight": "150px",
"euiPopoverArrowSize": "12px",
"euiPopoverTranslateDistance": "8px",
Expand Down
4 changes: 3 additions & 1 deletion src/components/accordion/__snapshots__/accordion.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1025,7 +1025,9 @@ exports[`EuiAccordion props isLoadingMessage is rendered 1`] = `
class="euiAccordion__children-isLoading"
>
<span
class="euiLoadingSpinner euiLoadingSpinner--medium euiAccordion__spinner"
aria-label="Loading"
class="euiLoadingSpinner euiAccordion__spinner css-155ohbx-euiLoadingSpinner-m"
role="progressbar"
/>
<span>
Please wait
Expand Down
4 changes: 3 additions & 1 deletion src/components/button/__snapshots__/button.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -312,7 +312,9 @@ exports[`EuiButton props isLoading is rendered 1`] = `
class="euiButtonContent euiButton__content"
>
<span
class="euiLoadingSpinner euiLoadingSpinner--medium euiButtonContent__spinner"
aria-label="Loading"
class="euiLoadingSpinner euiButtonContent__spinner css-155ohbx-euiLoadingSpinner-m"
role="progressbar"
/>
<span
class="euiButton__text"
Expand Down
8 changes: 6 additions & 2 deletions src/components/button/__snapshots__/button_content.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,9 @@ exports[`EuiButtonContent props isLoading is rendered 1`] = `
class="euiButtonContent"
>
<span
class="euiLoadingSpinner euiLoadingSpinner--medium euiButtonContent__spinner"
aria-label="Loading"
class="euiLoadingSpinner euiButtonContent__spinner css-155ohbx-euiLoadingSpinner-m"
role="progressbar"
/>
<span />
</span>
Expand All @@ -62,7 +64,9 @@ exports[`EuiButtonContent props isLoading replaces iconType with spinner 1`] = `
class="euiButtonContent"
>
<span
class="euiLoadingSpinner euiLoadingSpinner--medium euiButtonContent__spinner"
aria-label="Loading"
class="euiLoadingSpinner euiButtonContent__spinner css-155ohbx-euiLoadingSpinner-m"
role="progressbar"
/>
<span />
</span>
Expand Down
4 changes: 3 additions & 1 deletion src/components/button/button_empty/__snapshots__/button_empty.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -312,7 +312,9 @@ exports[`EuiButtonEmpty props isLoading is rendered 1`] = `
class="euiButtonContent euiButtonEmpty__content"
>
<span
class="euiLoadingSpinner euiLoadingSpinner--medium euiButtonContent__spinner"
aria-label="Loading"
class="euiLoadingSpinner euiButtonContent__spinner css-155ohbx-euiLoadingSpinner-m"
role="progressbar"
/>
<span
class="euiButtonEmpty__text"
Expand Down
4 changes: 3 additions & 1 deletion src/components/button/button_icon/__snapshots__/button_icon.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -254,7 +254,9 @@ exports[`EuiButtonIcon props isLoading is rendered 1`] = `
type="button"
>
<span
class="euiLoadingSpinner euiLoadingSpinner--medium"
aria-label="Loading"
class="euiLoadingSpinner css-155ohbx-euiLoadingSpinner-m"
role="progressbar"
/>
</button>
`;
Expand Down
4 changes: 3 additions & 1 deletion src/components/facet/__snapshots__/facet_button.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,9 @@ exports[`EuiFacetButton props isLoading is rendered 1`] = `
Content
</span>
<span
class="euiLoadingSpinner euiLoadingSpinner--medium euiFacetButton__spinner"
aria-label="Loading"
class="euiLoadingSpinner euiFacetButton__spinner css-155ohbx-euiLoadingSpinner-m"
role="progressbar"
/>
</span>
</button>
Expand Down
4 changes: 3 additions & 1 deletion src/components/form/field_password/__snapshots__/field_password.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -263,7 +263,9 @@ exports[`EuiFieldPassword props isLoading is rendered 1`] = `
class="euiFormControlLayoutIcons euiFormControlLayoutIcons--right"
>
<span
class="euiLoadingSpinner euiLoadingSpinner--medium"
aria-label="Loading"
class="euiLoadingSpinner css-155ohbx-euiLoadingSpinner-m"
role="progressbar"
/>
</div>
</div>
Expand Down
8 changes: 6 additions & 2 deletions src/components/form/form_control_layout/__snapshots__/form_control_layout.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,9 @@ exports[`EuiFormControlLayout props compressed renders small-sized icon, clear b
/>
</button>
<span
class="euiLoadingSpinner euiLoadingSpinner--small"
aria-label="Loading"
class="euiLoadingSpinner css-1y37fq2-euiLoadingSpinner-s"
role="progressbar"
/>
</div>
</div>
Expand Down Expand Up @@ -242,7 +244,9 @@ exports[`EuiFormControlLayout props isLoading is rendered 1`] = `
class="euiFormControlLayoutIcons euiFormControlLayoutIcons--right"
>
<span
class="euiLoadingSpinner euiLoadingSpinner--medium"
aria-label="Loading"
class="euiLoadingSpinner css-155ohbx-euiLoadingSpinner-m"
role="progressbar"
/>
</div>
</div>
Expand Down
4 changes: 3 additions & 1 deletion src/components/form/range/__snapshots__/dual_range.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -546,7 +546,9 @@ exports[`EuiDualRange props loading should display when showInput="inputWithPopo
class="euiFormControlLayoutIcons euiFormControlLayoutIcons--right"
>
<span
class="euiLoadingSpinner euiLoadingSpinner--medium"
aria-label="Loading"
class="euiLoadingSpinner css-155ohbx-euiLoadingSpinner-m"
role="progressbar"
/>
</div>
</div>
Expand Down
4 changes: 3 additions & 1 deletion src/components/form/range/__snapshots__/range.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -342,7 +342,9 @@ exports[`EuiRange props loading should display when showInput="inputWithPopover"
class="euiFormControlLayoutIcons euiFormControlLayoutIcons--right"
>
<span
class="euiLoadingSpinner euiLoadingSpinner--medium"
aria-label="Loading"
class="euiLoadingSpinner css-155ohbx-euiLoadingSpinner-m"
role="progressbar"
/>
</div>
</div>
Expand Down
4 changes: 3 additions & 1 deletion src/components/form/super_select/__snapshots__/super_select_control.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -272,7 +272,9 @@ Array [
class="euiFormControlLayoutIcons euiFormControlLayoutIcons--right"
>
<span
class="euiLoadingSpinner euiLoadingSpinner--medium"
aria-label="Loading"
class="euiLoadingSpinner css-155ohbx-euiLoadingSpinner-m"
role="progressbar"
/>
<span
class="euiFormControlLayoutCustomIcon"
Expand Down
1 change: 0 additions & 1 deletion src/components/index.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,6 @@
@import 'key_pad_menu/index';
@import 'link/index';
@import 'list_group/index';
@import 'loading/index';
@import 'markdown_editor/index';
@import 'modal/index';
@import 'notification/index';
Expand Down
Loading