Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CSS-in-JS] Convert EuiSkipLink #5851

Merged
merged 5 commits into from
Apr 28, 2022
Merged

[CSS-in-JS] Convert EuiSkipLink #5851

merged 5 commits into from
Apr 28, 2022

Conversation

thompsongl
Copy link
Contributor

@thompsongl thompsongl commented Apr 28, 2022 •
edited
Loading

Summary

Converts EuiSkipLink to @emotion styling.
Enforces non-null euiTheme.levels values via typing.

Checklist

  • Checked in both light and dark modes
  • Checked in Chrome, Safari, Edge, and Firefox
  • Props have proper autodocs and playground toggles
  • Checked Code Sandbox works for any docs examples
  • Added or updated jest and cypress tests
  • Checked for breaking changes and labeled appropriately
  • Checked for accessibility including keyboard-only and screenreader modes
  • A changelog entry exists and is marked appropriately

@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_5851/

cchaos
cchaos approved these changes Apr 28, 2022
View reviewed changes
Copy link
Contributor

@cchaos cchaos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with just one change needed for logical properties.

src/components/accessibility/skip_link/skip_link.styles.ts Outdated Show resolved Hide resolved
@thompsongl @cchaos
Update src/components/accessibility/skip_link/skip_link.styles.ts
830059f 
Co-authored-by: Caroline Horn <549577+cchaos@users.noreply.github.com>
@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_5851/

@thompsongl thompsongl enabled auto-merge (squash) April 28, 2022 18:54
@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_5851/

@thompsongl thompsongl merged commit 4660508 into elastic:main Apr 28, 2022
@thompsongl thompsongl mentioned this pull request Apr 29, 2022
Closed
49 tasks
@breehall breehall mentioned this pull request May 16, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cchaos cchaos cchaos approved these changes

Assignees
No one assigned
Labels
emotion
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@thompsongl @kibanamachine @cchaos