Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EuiPanel] Add missing Emotion styles when panel render as button #6010

Merged
merged 3 commits into from
Jun 29, 2022

Conversation

miukimiu
Copy link
Contributor

@miukimiu miukimiu commented Jun 29, 2022

Summary

Fixes #6009.

This PR fixes an issue with EuiPanel where the Emotion styles were not being passed when it was rendered as a button.

Checklist

  • Checked in both light and dark modes
  • [ ] Checked in mobile
  • Checked in Chrome, Safari, Edge, and Firefox
  • [ ] Props have proper autodocs and playground toggles
  • [ ] Added documentation
  • [ ] Checked Code Sandbox works for any docs examples
  • Added or updated jest and cypress tests
  • [ ] Checked for breaking changes and labeled appropriately
  • [ ] Checked for accessibility including keyboard-only and screenreader modes
  • [ ] Updated the Figma library counterpart
  • A changelog entry exists and is marked appropriately

@miukimiu miukimiu changed the title [EuiPanel] Add missing Emotionstyles when panel render as button [EuiPanel] Add missing Emotion styles when panel render as button Jun 29, 2022
@miukimiu miukimiu marked this pull request as ready for review June 29, 2022 11:16
@miukimiu miukimiu requested a review from flash1293 June 29, 2022 11:18
@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_6010/

Copy link
Contributor

@thompsongl thompsongl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @miukimiu!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[EuiPanel] Emotion styles not applied when rendering as button
3 participants