[CSS-in-JS] Convert EuiErrorBoundary
#6053
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
49 tasks
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_6053/ |
miukimiu
approved these changes
Jul 18, 2022
| EuiErrorBoundaryProps, | ||
| type EuiErrorBoundaryExtendedProps = EuiErrorBoundaryProps & WithEuiThemeProps; | ||
|
|
||
| export class _EuiErrorBoundary extends Component< |
There was a problem hiding this comment.
Should this component be converted to a function component?
There was a problem hiding this comment.
Unfortunately it's not yet possible: https://reactjs.org/docs/hooks-faq.html#do-hooks-cover-all-use-cases-for-classes
We need componentDidCatch for this to function and there is no way to achieve that without a class component.
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_6053/ |
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_6053/ |
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_6053/ |
|
@thompsongl it's looking good in Safari 15.4! 🎉
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Converts
EuiErrorBoundaryto@emotionstyling.Note that if you run this locally, the error overlay on the Error Boundary docs page is expected.
Checklist