Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[eui.d.ts] Exclude all of src/test #6142

Merged
merged 4 commits into from
Aug 15, 2022

Conversation

thompsongl
Copy link
Contributor

@thompsongl thompsongl commented Aug 15, 2022

Summary

Required for elastic/kibana#138837

The exclude glob pattern for the d.ts generator script was not accounting for nested directories with TS files. The result was that src/test/rtl/ and src/test/internal/ files and types were included in eui.d.ts (like, specifically the ones we don't want to include 🙈) and in turn included problematic types from RTL that interfere with other testing lib type definitions.

Verification:

  • Checkout the v62.2.1 tag
  • yarn
  • Generate a new eui.d.ts
  • Drop that eui.d.ts in the Kibana upgrade branch
  • Type errors related to this in, say test/functional/apps/console/_autocomplete.ts should be resolved

Checklist

  • Checked for breaking changes and labeled appropriately
  • A changelog entry exists and is marked appropriately

@thompsongl thompsongl changed the title [eui.d.ts] Exlcude _all_ of src/test [eui.d.ts] Exclude all of src/test Aug 15, 2022
Copy link
Member

@cee-chen cee-chen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oof, awesome catch on this!!

@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_6142/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants