[EuiDescriptionListTitle] Fix compressed styles not being correctly applied #6160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… the compressed style unless the textStyle is reversed.
thompsongl
reviewed
Aug 23, 2022
| @@ -31,7 +31,7 @@ export const EuiDescriptionListTitle: FunctionComponent<EuiDescriptionListTitleP | |||
| const styles = euiDescriptionListTitleStyles(theme); | |||
|
|
|||
| let conditionalStyles = | |||
| compressed && textStyle === 'reverse' | |||
| compressed && textStyle !== 'reverse' | |||
There was a problem hiding this comment.
Any reason reverse and compressed can't be applied at the same time?
There was a problem hiding this comment.
They can, but the scss styles for a compressed+reversed title reset the compression styles back to their base, non-compressed form
There was a problem hiding this comment.
I guess that actually means they can't (for title), doesn't it.
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_6160/ |
cee-chen
changed the title
cee-chen
changed the title
cee-chen
reviewed
Aug 23, 2022
Co-authored-by: Constance <constancecchen@users.noreply.github.com>
thompsongl
approved these changes
Aug 23, 2022
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_6160/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Resolved a bug that caused
compressedstyles not to be applied to text in the original Emotion conversion ofEuiDescriptionList. The text within theDescriptionListTitleandDescriptionListDescriptionshould be 14px when the DescriptionList is compressed.Resolved: Text = 14px
Previous: Text = 16px
Checklist