Remove IE flex and display CSS fixes & fallbacks #6161
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- truncation and display still appears to all work as before without issue
- flex-grow is still necessary for icons to be pushed to the right
- looks to have been missed in the Emotion conversion
- likely not necessary to test as EuiPageContent is deprecated
- not sure if this causes unexpected issues :/
|
@miukimiu tagging you in both PRs as well for the CSS changes, and also because you're amazing at QA 🙇 No rush on these PRs, take your time! |
cee-chen
commented
Aug 23, 2022
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_6161/ |
16 tasks
miukimiu
approved these changes
Aug 24, 2022
There was a problem hiding this comment.
Thanks, @constancecchen.
I tested all the components in Chrome, Safari, and Firefox:
- EuiModal
- EuiBadge
- EuiCard
- EuiForm
- delimited icons & compressed inputs
- compressedColumn label widths
- EuiListGroup
- EuiBasicTable mobile cells
- EuiFlexGroup / EuiFlexItem (Let's keep the
flex-grow: 1;) -
EuiPageContentnot worth testing as it's a deprecated component
LGTM! 🎉 Let's just keep that .euiFlexGroup { flex-grow: 1;}.
|
Thanks a million Elizabet!! |
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_6161/ |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Follow up to #6154. While #6154 is a set of fairly safe IE fallback removals, this PR is slightly more risky (particularly dadedf1), and is a separate PR for more granular testing and potentially easier rollback if needed.
Components to QA
EuiPageContentnot worth testing as it's a deprecated componentChecklist
- [ ] Props have proper autodocs and playground toggles- [ ] Added documentation- [ ] Checked Code Sandbox works for any docs examples- [ ] Added or updated jest and cypress tests- [ ] Checked for accessibility including keyboard-only and screenreader modes- [ ] Updated the Figma library counterpart