-
Notifications
You must be signed in to change notification settings - Fork 837
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Emotion] Convert EuiListGroup
#6207
Commits on Sep 5, 2022
-
Configuration menu - View commit details
-
Copy full SHA for b02e168 - Browse repository at this point
Copy the full SHA b02e168View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7164bc7 - Browse repository at this point
Copy the full SHA 7164bc7View commit details
Commits on Sep 6, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 93d5433 - Browse repository at this point
Copy the full SHA 93d5433View commit details
Commits on Sep 7, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 10a3b8f - Browse repository at this point
Copy the full SHA 10a3b8fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 0ff3a06 - Browse repository at this point
Copy the full SHA 0ff3a06View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1fad37b - Browse repository at this point
Copy the full SHA 1fad37bView commit details
Commits on Sep 8, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 92135e6 - Browse repository at this point
Copy the full SHA 92135e6View commit details -
Configuration menu - View commit details
-
Copy full SHA for bb45f94 - Browse repository at this point
Copy the full SHA bb45f94View commit details
Commits on Sep 9, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 1c168b6 - Browse repository at this point
Copy the full SHA 1c168b6View commit details
Commits on Sep 12, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 2304ec2 - Browse repository at this point
Copy the full SHA 2304ec2View commit details
Commits on Sep 13, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 115a08b - Browse repository at this point
Copy the full SHA 115a08bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 8375cb1 - Browse repository at this point
Copy the full SHA 8375cb1View commit details -
Configuration menu - View commit details
-
Copy full SHA for a3b18ed - Browse repository at this point
Copy the full SHA a3b18edView commit details -
Configuration menu - View commit details
-
Copy full SHA for 2aa9ad1 - Browse repository at this point
Copy the full SHA 2aa9ad1View commit details -
Configuration menu - View commit details
-
Copy full SHA for c08bacb - Browse repository at this point
Copy the full SHA c08bacbView commit details -
Configuration menu - View commit details
-
Copy full SHA for f476e97 - Browse repository at this point
Copy the full SHA f476e97View commit details -
Configuration menu - View commit details
-
Copy full SHA for 385117c - Browse repository at this point
Copy the full SHA 385117cView commit details
Commits on Sep 14, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 99d699d - Browse repository at this point
Copy the full SHA 99d699dView commit details
Commits on Sep 19, 2022
-
Configuration menu - View commit details
-
Copy full SHA for c9cedf9 - Browse repository at this point
Copy the full SHA c9cedf9View commit details
Commits on Sep 20, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 6ab15cd - Browse repository at this point
Copy the full SHA 6ab15cdView commit details -
[PR feedback ] misc test/css tweaks
- make `css` merging as top-level prop and as iconProps work correctly - add requiredProps to basic renders test
Configuration menu - View commit details
-
Copy full SHA for 9452c15 - Browse repository at this point
Copy the full SHA 9452c15View commit details -
[PR feedback] Remove unnecessary
euiListGroupItemInnerStyles
args i……n favor of array logic
Configuration menu - View commit details
-
Copy full SHA for 1f3261f - Browse repository at this point
Copy the full SHA 1f3261fView commit details -
[PR feedback] Remove
euiListGroupItemStyles
in favor of array condi……tionals & obj keys + DRY out repeated euiBackgroundColor() calls
Configuration menu - View commit details
-
Copy full SHA for 5674a7a - Browse repository at this point
Copy the full SHA 5674a7aView commit details -
Configuration menu - View commit details
-
Copy full SHA for ae3daf2 - Browse repository at this point
Copy the full SHA ae3daf2View commit details -
Configuration menu - View commit details
-
Copy full SHA for e0398b3 - Browse repository at this point
Copy the full SHA e0398b3View commit details -
Configuration menu - View commit details
-
Copy full SHA for cb864e2 - Browse repository at this point
Copy the full SHA cb864e2View commit details -
[EuiListGroupItemExtraAction] Export props type and document more cle…
…arly in props table + move alwayShow to top of props list
Configuration menu - View commit details
-
Copy full SHA for b5b656b - Browse repository at this point
Copy the full SHA b5b656bView commit details -
[EuiListGroupItemExtraAction] Fix non-working hover/focus CSS selectors
- `.euiListGroupItem-isDisabled` is no longer a className, so the :not() selector is not working and the action still appears on hover on disabled items - passing `parentIsDisabled` as an internal prop from EuiListGroupItem and making it an array conditional solves the hover issue - the parent li is not focusable so the `:focus &` selector doesn't work either. Changing it to to the button and `+ &` solves the issue + remove unnecessary comment
Configuration menu - View commit details
-
Copy full SHA for a12e1c8 - Browse repository at this point
Copy the full SHA a12e1c8View commit details -
[EuiListGroupItemExtraAction] Add basic unit tests + clean up styles …
…array further - the hover CSS is unnecessary if alwaysShow is true, so add a condition for it
Configuration menu - View commit details
-
Copy full SHA for 49a2188 - Browse repository at this point
Copy the full SHA 49a2188View commit details -
Configuration menu - View commit details
-
Copy full SHA for c2591c8 - Browse repository at this point
Copy the full SHA c2591c8View commit details -
[EuiListGroupItemExtraAction] Fix margin-right spacing
- currently 8px on prod which generally seems to match the button padding size better
Configuration menu - View commit details
-
Copy full SHA for 4e1de76 - Browse repository at this point
Copy the full SHA 4e1de76View commit details -
[Enhancement] Improve button hitbox of tooltip wrapped items
- this allows button content inside tooltips to grow to 100% of the EuiListGroupItem - this is an enhancement from current prod behavior
Configuration menu - View commit details
-
Copy full SHA for d41fa9a - Browse repository at this point
Copy the full SHA d41fa9aView commit details -
- Remove unnecessary CSS on __inner - the width: 100% is totally unnecessary (tested with both extra action and without) and the word break can be applied to the __label CSS instead - DRY out unsetting CSS by using ternary instead of base CSS (but keep empty base for naming) - DRY out CSS by using text utils
Configuration menu - View commit details
-
Copy full SHA for 19e3850 - Browse repository at this point
Copy the full SHA 19e3850View commit details -
Configuration menu - View commit details
-
Copy full SHA for 425ce47 - Browse repository at this point
Copy the full SHA 425ce47View commit details -
Fix/cleanup misc custom maxWidth behavior
- use logical CSS property instead of max-width - do not apply maxWidthDefault emotion style if using a custom inline max-width - fix maxWidth conditional checks - remove || fallback / type def in favor of let - improve props documentation/typing
Configuration menu - View commit details
-
Copy full SHA for 28aa0bd - Browse repository at this point
Copy the full SHA 28aa0bdView commit details -
Configuration menu - View commit details
-
Copy full SHA for ec20ddb - Browse repository at this point
Copy the full SHA ec20ddbView commit details -
Configuration menu - View commit details
-
Copy full SHA for 86615c1 - Browse repository at this point
Copy the full SHA 86615c1View commit details -
Configuration menu - View commit details
-
Copy full SHA for aa206a5 - Browse repository at this point
Copy the full SHA aa206a5View commit details -
[EuiListGroupItem] Add working
shouldRenderCustomStyles
+ test nested `iconProps` and `extraAction` props + fix `extraAction` props not correctly passing/merging `className` + fix misc console.warn about missing EuiButtonIcon aria-label + add test for `style` prop on parent EuiListGroupItem, since it gets spread to the wrapped child and not the className wrapper
Configuration menu - View commit details
-
Copy full SHA for 24fc328 - Browse repository at this point
Copy the full SHA 24fc328View commit details -
Remove
euiPinnableListGroup__itemExtraAction
classes- they're now being correctly passed to the `EuiListGroupItemExtraAction` but they're not really doing anything / just adding a lot of noise - consumers can simply hook into `.euiListGroupItemExtraAction` instead - no Kibana references to these classes, so IMO they're safe to remove
Configuration menu - View commit details
-
Copy full SHA for 49fb14f - Browse repository at this point
Copy the full SHA 49fb14fView commit details