Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Emotion] Convert EuiResizableContainer and EuiResizablePanel #6287

Merged
merged 9 commits into from
Oct 18, 2022
Merged

[Emotion] Convert EuiResizableContainer and EuiResizablePanel #6287

merged 9 commits into from
Oct 18, 2022

Commits on Oct 4, 2022

  1. [EuiResizableContainer] Convert styles

    @cee-chen
    cee-chen committed Oct 4, 2022
    Configuration menu
    Copy the full SHA
    9bba9e3 View commit details
    Browse the repository at this point in the history

  2. [EuiResizablePanel] Emotion setup 

    - basic styles only
- leave wrapper modifier classes in for now - will handle in another commit
+ rename inlineStyles due to var name conflict
    @cee-chen
    cee-chen committed Oct 4, 2022
    Configuration menu
    Copy the full SHA
    f7cf6d8 View commit details
    Browse the repository at this point in the history

  3. [EuiResizablePanel] Convert & update padding CSS 

    - Add new `euiPaddingSizeCSS` util that our internal components can use to generate a CSS map, and update `useEuiPaddingSize` to call that util instead of being its own fn

- Remove panel padding size map in favor of calling euiPaddingSize util directly

- Remove modifier map and ts error

+ add wrapperPadding unit test
    @cee-chen
    cee-chen committed Oct 4, 2022
    Configuration menu
    Copy the full SHA
    1b46414 View commit details
    Browse the repository at this point in the history

  4. [EuiResizablePanel] Convert remaining collapse CSS to Emotion 

    + DRY out axis direction to a const
    @cee-chen
    cee-chen committed Oct 4, 2022
    Configuration menu
    Copy the full SHA
    f0215ff View commit details
    Browse the repository at this point in the history

  5. [EuiResizablePanel] Remove remaining modifier classes in favor of dat… 

    …a attributes

- left out isCollapsible modifier - consumers can likely look for the collapsible button instead

+ fix misc parseInt usage missing `10` radix - prefer parseFloat instead
    @cee-chen
    cee-chen committed Oct 4, 2022
    Configuration menu
    Copy the full SHA
    dfe6fab View commit details
    Browse the repository at this point in the history

  6. [EuiResizablePanel] Convert inline style dimensions to logical proper… 

    …ties

+ simplify conditional logic

+ fix logicalSizeStyle util not correctly camelCasing keys
    @cee-chen
    cee-chen committed Oct 4, 2022
    Configuration menu
    Copy the full SHA
    6d1076a View commit details
    Browse the repository at this point in the history

  7. [EuiResizablePanel] Remove Sass files

    @cee-chen
    cee-chen committed Oct 4, 2022
    Configuration menu
    Copy the full SHA
    3198757 View commit details
    Browse the repository at this point in the history

  8. [docs] Convert all resizable examples to Typescript

    @cee-chen
    cee-chen committed Oct 4, 2022
    Configuration menu
    Copy the full SHA
    5ebfea3 View commit details
    Browse the repository at this point in the history

  9. Changelog

    @cee-chen
    cee-chen committed Oct 4, 2022
    Configuration menu
    Copy the full SHA
    814baa4 View commit details
    Browse the repository at this point in the history