-
Notifications
You must be signed in to change notification settings - Fork 837
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[EuiBeacon] Add color prop #6420
Merged
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
c6f5542
[EuiBeacon] Add color prop
dawitamene ac3f76b
Add CL entry
dawitamene 002654c
Omit color field from HTMLAttributes
dawitamene 37b613f
Remove color parameter from Emotion style function and return styles …
dawitamene c52d847
Merge remote-tracking branch 'upstream/main' into beacon/color-prop
cee-chen File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,19 +1,73 @@ | ||
// Jest Snapshot v1, https://goo.gl/fbAQLP | ||
|
||
exports[`EuiBeacon accepts size 1`] = ` | ||
exports[`EuiBeacon is rendered 1`] = ` | ||
<div | ||
aria-label="aria-label" | ||
class="euiBeacon testClass1 testClass2 emotion-euiBeacon" | ||
class="euiBeacon testClass1 testClass2 emotion-euiBeacon-success" | ||
data-test-subj="test subject string" | ||
style="height:14px;width:14px" | ||
style="height:12px;width:12px" | ||
/> | ||
`; | ||
|
||
exports[`EuiBeacon is rendered 1`] = ` | ||
exports[`EuiBeacon props color accent is rendered 1`] = ` | ||
<div | ||
aria-label="aria-label" | ||
class="euiBeacon testClass1 testClass2 emotion-euiBeacon-accent" | ||
data-test-subj="test subject string" | ||
style="height:12px;width:12px" | ||
/> | ||
`; | ||
|
||
exports[`EuiBeacon props color danger is rendered 1`] = ` | ||
<div | ||
aria-label="aria-label" | ||
class="euiBeacon testClass1 testClass2 emotion-euiBeacon-danger" | ||
data-test-subj="test subject string" | ||
style="height:12px;width:12px" | ||
/> | ||
`; | ||
|
||
exports[`EuiBeacon props color primary is rendered 1`] = ` | ||
<div | ||
aria-label="aria-label" | ||
class="euiBeacon testClass1 testClass2 emotion-euiBeacon-primary" | ||
data-test-subj="test subject string" | ||
style="height:12px;width:12px" | ||
/> | ||
`; | ||
|
||
exports[`EuiBeacon props color subdued is rendered 1`] = ` | ||
<div | ||
aria-label="aria-label" | ||
class="euiBeacon testClass1 testClass2 emotion-euiBeacon-subdued" | ||
data-test-subj="test subject string" | ||
style="height:12px;width:12px" | ||
/> | ||
`; | ||
|
||
exports[`EuiBeacon props color success is rendered 1`] = ` | ||
<div | ||
aria-label="aria-label" | ||
class="euiBeacon testClass1 testClass2 emotion-euiBeacon" | ||
class="euiBeacon testClass1 testClass2 emotion-euiBeacon-success" | ||
data-test-subj="test subject string" | ||
style="height:12px;width:12px" | ||
/> | ||
`; | ||
|
||
exports[`EuiBeacon props color warning is rendered 1`] = ` | ||
<div | ||
aria-label="aria-label" | ||
class="euiBeacon testClass1 testClass2 emotion-euiBeacon-warning" | ||
data-test-subj="test subject string" | ||
style="height:12px;width:12px" | ||
/> | ||
`; | ||
|
||
exports[`EuiBeacon props size accepts size 1`] = ` | ||
<div | ||
aria-label="aria-label" | ||
class="euiBeacon testClass1 testClass2 emotion-euiBeacon-success" | ||
data-test-subj="test subject string" | ||
style="height:14px;width:14px" | ||
/> | ||
`; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
- Added `color` prop to `EuiBeacon` |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very minor / optional code organization - I'd add a newline between blocks and leave this as its own
test
vs giving it a describe blockThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@constancecchen I agree. I tried to commit, but build process is failing with this error.
I checked
EuiFocusTrap
's props and there's nopreventScrollOnFocus
prop.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's a super bizarre error since it's not related to EuiBeacon 🤔 - I recently merged in latest main into this branch in order to kickstart CI, so I'm guessing what happened is you may need to re-run
yarn
to fix type definitions.No worries at all though as this was a super optional comment! Thank you again for your great work!