Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[EuiTab] Fix prepend/append elements not inheriting selected colors + misc CSS cleanup #6938

Merged
merged 5 commits into from
Jul 12, 2023
Merged

[EuiTab] Fix prepend/append elements not inheriting selected colors + misc CSS cleanup #6938

merged 5 commits into from
Jul 12, 2023

Commits on Jul 12, 2023

  1. Fix EuiTab icons not inheriting the selected color

    @cee-chen
    cee-chen committed Jul 12, 2023
    Configuration menu
    Copy the full SHA
    fb8c61c View commit details
    Browse the repository at this point in the history

  2. Clean up tab CSS to reduce unnecessary color setting/overrides 

    - Using the `euiTitle()` util gives us too much we don't need (color, font-weight, etc.) - it makes more sense to simply use `euiFontSize` directly

- doing so allows us to set `color` once on the parent button
    @cee-chen
    cee-chen committed Jul 12, 2023
    Configuration menu
    Copy the full SHA
    c501df3 View commit details
    Browse the repository at this point in the history

  3. More CSS cleanup 

    - focus and hover styles aren't necessary or doing anything - remove them
    @cee-chen
    cee-chen committed Jul 12, 2023
    Configuration menu
    Copy the full SHA
    bd0183d View commit details
    Browse the repository at this point in the history

  4. Update snapshots

    @cee-chen
    cee-chen committed Jul 12, 2023
    Configuration menu
    Copy the full SHA
    4552434 View commit details
    Browse the repository at this point in the history

  5. changelog

    @cee-chen
    cee-chen committed Jul 12, 2023
    Configuration menu
    Copy the full SHA
    4b124aa View commit details
    Browse the repository at this point in the history