Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[EuiProvider] Add a check and dev warning+early return for nested usage #6949

Merged
merged 12 commits into from
Jul 17, 2023
Merged

[EuiProvider] Add a check and dev warning+early return for nested usage #6949

merged 12 commits into from
Jul 17, 2023

Commits on Jul 13, 2023

  1. [setup] DRY out warning logic and write more robust unit tests for it

    @cee-chen
    cee-chen committed Jul 13, 2023
    Configuration menu
    Copy the full SHA
    a8df8cc View commit details
    Browse the repository at this point in the history

  2. [cleanup] Move EuiThemeProvider nested tests to theme provider file 

    - they don't really belong in `EuiProvider`
    @cee-chen
    cee-chen committed Jul 13, 2023
    Configuration menu
    Copy the full SHA
    89e61de View commit details
    Browse the repository at this point in the history

  3. [cleanup] Improve EuiThemeProvider's unit testing 

    - make `EuiProvider`s tests more basic in comparison

- use `toHaveStyleRule` instead of snapshots
    @cee-chen
    cee-chen committed Jul 13, 2023
    Configuration menu
    Copy the full SHA
    f2d0903 View commit details
    Browse the repository at this point in the history

  4. [cleanup] Convert more EuiProvider tests to RTL from Enzyme

    @cee-chen
    cee-chen committed Jul 13, 2023
    Configuration menu
    Copy the full SHA
    fe02eb1 View commit details
    Browse the repository at this point in the history

  5. [cleanup] Convert EuiProvider cache tests to RTL from Enzyme

    @cee-chen
    cee-chen committed Jul 13, 2023
    Configuration menu
    Copy the full SHA
    13a4bf3 View commit details
    Browse the repository at this point in the history

  6. Set up a context to check for nested EuiProviders

    @cee-chen
    cee-chen committed Jul 13, 2023
    Configuration menu
    Copy the full SHA
    73bf66c View commit details
    Browse the repository at this point in the history

  7. Update EuiProvider to return early and emit a warning if nested usa… 

    …ge is detected
    @cee-chen
    cee-chen committed Jul 13, 2023
    Configuration menu
    Copy the full SHA
    365e6e3 View commit details
    Browse the repository at this point in the history

  8. Fix types on EuiProvider's props table

    @cee-chen
    cee-chen committed Jul 13, 2023
    Configuration menu
    Copy the full SHA
    61e8630 View commit details
    Browse the repository at this point in the history

Commits on Jul 14, 2023

  1. [docs] Improve EuiProvider and EuiThemeProvider docs 

    - clarify in as many places as possible

- remove uncertain language (e.g. 'currently', 'future') that were still not yet figured out when docs were written

- try to remove overlap in docs between provider and theme provider, try to clarify nested usage of theme provider

- add examples to warning section
    @cee-chen
    cee-chen committed Jul 14, 2023
    Configuration menu
    Copy the full SHA
    a9a4725 View commit details
    Browse the repository at this point in the history

  2. changelog

    @cee-chen
    cee-chen committed Jul 14, 2023
    Configuration menu
    Copy the full SHA
    16f08a4 View commit details
    Browse the repository at this point in the history

Commits on Jul 15, 2023

  1. Fix Cypress tests failing due to nested EuiProviders

    @cee-chen
    cee-chen committed Jul 15, 2023
    Configuration menu
    Copy the full SHA
    1db5f22 View commit details
    Browse the repository at this point in the history

Commits on Jul 17, 2023

  1. [PR feedback] Allow cy.mount to have a configurable provider props

    @cee-chen
    cee-chen committed Jul 17, 2023
    Configuration menu
    Copy the full SHA
    0fadabd View commit details
    Browse the repository at this point in the history