-
Notifications
You must be signed in to change notification settings - Fork 837
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[EuiComboBox] Update to dogfood EuiTextTruncate
#7028
Commits on Aug 2, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 23aba4c - Browse repository at this point
Copy the full SHA 23aba4cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 00720dc - Browse repository at this point
Copy the full SHA 00720dcView commit details -
Configuration menu - View commit details
-
Copy full SHA for 8b67204 - Browse repository at this point
Copy the full SHA 8b67204View commit details -
Configuration menu - View commit details
-
Copy full SHA for 00241ea - Browse repository at this point
Copy the full SHA 00241eaView commit details -
Configuration menu - View commit details
-
Copy full SHA for df85489 - Browse repository at this point
Copy the full SHA df85489View commit details
Commits on Aug 3, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 83bd86a - Browse repository at this point
Copy the full SHA 83bd86aView commit details -
Configuration menu - View commit details
-
Copy full SHA for ea1be6c - Browse repository at this point
Copy the full SHA ea1be6cView commit details -
Configuration menu - View commit details
-
Copy full SHA for cb37976 - Browse repository at this point
Copy the full SHA cb37976View commit details
Commits on Aug 20, 2023
-
Configuration menu - View commit details
-
Copy full SHA for e269b00 - Browse repository at this point
Copy the full SHA e269b00View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1aeec8c - Browse repository at this point
Copy the full SHA 1aeec8cView commit details
Commits on Aug 21, 2023
-
Configuration menu - View commit details
-
Copy full SHA for e07791d - Browse repository at this point
Copy the full SHA e07791dView commit details -
Set up
EuiTextTruncate
componentTODO: tests TODO: figure out how to incorporate combobox's search highlighting TODO: update combobox to dogfood this component
Configuration menu - View commit details
-
Copy full SHA for 6131706 - Browse repository at this point
Copy the full SHA 6131706View commit details -
Configuration menu - View commit details
-
Copy full SHA for ce0bf7e - Browse repository at this point
Copy the full SHA ce0bf7eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 0261f23 - Browse repository at this point
Copy the full SHA 0261f23View commit details -
More component cleanup/changes
- Write prop docs - Rename `separator` prop to `ellipsis` - Tweak ellipsis check to return an empty string / not completely throw and simply error instead - Resize observer - separate to its own component for performance/readability, + tweak conditional to check for `undefined` rather falling back if `0` (may matter for initial render) - Rename internal `EuiTextTruncateToWidth` to `EuiTextTruncateWithWidth`
Configuration menu - View commit details
-
Copy full SHA for 79cb351 - Browse repository at this point
Copy the full SHA 79cb351View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3f9671f - Browse repository at this point
Copy the full SHA 3f9671fView commit details -
Configuration menu - View commit details
-
Copy full SHA for d5d6f3d - Browse repository at this point
Copy the full SHA d5d6f3dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 006eefa - Browse repository at this point
Copy the full SHA 006eefaView commit details
Commits on Aug 22, 2023
-
[typing] Make
truncation
prop optionalsince we're already defaulting to `end`
Configuration menu - View commit details
-
Copy full SHA for 0c0703c - Browse repository at this point
Copy the full SHA 0c0703cView commit details -
Rename
startEndAnchor
totruncationPosition
+ other cleanup- clean up storybook props DX some - clean up useMemo logic for `truncation` and `truncationOffset` props - prefer moving all logic to a single memo that returns multiple values
Configuration menu - View commit details
-
Copy full SHA for 572ce0c - Browse repository at this point
Copy the full SHA 572ce0cView commit details -
- majority of testing is in Cypress, since JSdom has no concept of dimensions/width
Configuration menu - View commit details
-
Copy full SHA for 09cc1c3 - Browse repository at this point
Copy the full SHA 09cc1c3View commit details -
Add docs page and examples for new component
+ fix resizable story to use inline resize on supported browsers
Configuration menu - View commit details
-
Copy full SHA for b45b719 - Browse repository at this point
Copy the full SHA b45b719View commit details -
Configuration menu - View commit details
-
Copy full SHA for 17047d1 - Browse repository at this point
Copy the full SHA 17047d1View commit details -
Improve screen reader and copy UX
- at the cost of more repetitive DOM, but I think the tradeoff here is worth it
Configuration menu - View commit details
-
Copy full SHA for 1af3b49 - Browse repository at this point
Copy the full SHA 1af3b49View commit details -
Configuration menu - View commit details
-
Copy full SHA for f46b348 - Browse repository at this point
Copy the full SHA f46b348View commit details -
Add new
truncationProps
andrenderTruncatedOption
logic- that dogfoods `EuiTextTruncate` + add support for configuring truncation for all options and individual options + remove `title` attr, should alreaedy be handled by EuiTextTruncate + opinionated reordering of imports + clean up unnecessary `data-test-subj` prop (already inherited from CommonProps) + remove `OPTION_CONTENT_CLASSNAME` const by always rendering the `__content` wrapper regardless of render method
Configuration menu - View commit details
-
Copy full SHA for 8491224 - Browse repository at this point
Copy the full SHA 8491224View commit details -
Configuration menu - View commit details
-
Copy full SHA for c69441a - Browse repository at this point
Copy the full SHA c69441aView commit details
Commits on Aug 23, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 10dc0e2 - Browse repository at this point
Copy the full SHA 10dc0e2View commit details -
Configuration menu - View commit details
-
Copy full SHA for f219119 - Browse repository at this point
Copy the full SHA f219119View commit details -
Clean up
truncationOffset
edge case behavior- the new utils allowed me to see how to attempt to continue truncating the logic rather than just metaphorically throwing hands in the air!
Configuration menu - View commit details
-
Copy full SHA for 64aaebd - Browse repository at this point
Copy the full SHA 64aaebdView commit details -
- `truncationPosition` can't be set back to undefined if it starts as a number
Configuration menu - View commit details
-
Copy full SHA for 7d5ce5a - Browse repository at this point
Copy the full SHA 7d5ce5aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 5fd309e - Browse repository at this point
Copy the full SHA 5fd309eView commit details -
[PR feedback] Expand utilities for to specify DOM vs. canvas render m…
…ethods + write more detailed jsdoc comments/descriptions + add a Cypress spec to confirm canvas util works correctly
Configuration menu - View commit details
-
Copy full SHA for a5837bb - Browse repository at this point
Copy the full SHA a5837bbView commit details -
Configuration menu - View commit details
-
Copy full SHA for 767a44e - Browse repository at this point
Copy the full SHA 767a44eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 4cd6ad5 - Browse repository at this point
Copy the full SHA 4cd6ad5View commit details
Commits on Aug 24, 2023
-
- apparently has zero fonts in common with my machine, so google fonts it is + clean up previous font loading code - we only need 1 weight, and we can use `before()` instead of a mount util
Configuration menu - View commit details
-
Copy full SHA for 85ccc1c - Browse repository at this point
Copy the full SHA 85ccc1cView commit details -
[PR feedback] Improve perf of DOM measurement
+ harden standalone behavior
Configuration menu - View commit details
-
Copy full SHA for a1c487d - Browse repository at this point
Copy the full SHA a1c487dView commit details -
Update
EuiTextTruncate
to support usingTruncationUtilsForCanvas
+ re-add the font computation method Marco originally had in the canvas class, and require passing in either a font string or a container to compute fonts from
Configuration menu - View commit details
-
Copy full SHA for b6b67b0 - Browse repository at this point
Copy the full SHA b6b67b0View commit details -
Add documentation section and warnings around performance
+ example where the perf differences between various recommended mitigations can be tested
Configuration menu - View commit details
-
Copy full SHA for f4a9af4 - Browse repository at this point
Copy the full SHA f4a9af4View commit details -
- add basic unit test for confirming that the right utils areb eing called - add missing E2E test for resize observer behavior
Configuration menu - View commit details
-
Copy full SHA for 4a96de8 - Browse repository at this point
Copy the full SHA 4a96de8View commit details
Commits on Aug 25, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 879b38e - Browse repository at this point
Copy the full SHA 879b38eView commit details -
- remove truncation error testing from the main component - we're already testing that in the utils unit tests - reorganize utils E2E tests slightly for readability - misc wording fixes
Configuration menu - View commit details
-
Copy full SHA for 30196af - Browse repository at this point
Copy the full SHA 30196afView commit details
Commits on Sep 1, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 6718b37 - Browse repository at this point
Copy the full SHA 6718b37View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5098c4c - Browse repository at this point
Copy the full SHA 5098c4cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 3cb8c0d - Browse repository at this point
Copy the full SHA 3cb8c0dView commit details
Commits on Sep 18, 2023
-
Configuration menu - View commit details
-
Copy full SHA for e28a66e - Browse repository at this point
Copy the full SHA e28a66eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 998ecb1 - Browse repository at this point
Copy the full SHA 998ecb1View commit details -
Configuration menu - View commit details
-
Copy full SHA for d188bb5 - Browse repository at this point
Copy the full SHA d188bb5View commit details -
Configuration menu - View commit details
-
Copy full SHA for b971297 - Browse repository at this point
Copy the full SHA b971297View commit details