Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EuiComboBox] Update to dogfood EuiTextTruncate #7028

Merged
merged 49 commits into from
Sep 18, 2023
Merged

Commits on Aug 2, 2023

  1. Configuration menu
    Copy the full SHA
    23aba4c View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    00720dc View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    8b67204 View commit details
    Browse the repository at this point in the history
  4. 📝 Update documentation

    dej611 committed Aug 2, 2023
    Configuration menu
    Copy the full SHA
    00241ea View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    df85489 View commit details
    Browse the repository at this point in the history

Commits on Aug 3, 2023

  1. Configuration menu
    Copy the full SHA
    83bd86a View commit details
    Browse the repository at this point in the history
  2. 🔥 Remove ellipsis

    dej611 committed Aug 3, 2023
    Configuration menu
    Copy the full SHA
    ea1be6c View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    cb37976 View commit details
    Browse the repository at this point in the history

Commits on Aug 20, 2023

  1. Configuration menu
    Copy the full SHA
    e269b00 View commit details
    Browse the repository at this point in the history
  2. Revert yarn.lock changes

    cee-chen committed Aug 20, 2023
    Configuration menu
    Copy the full SHA
    1aeec8c View commit details
    Browse the repository at this point in the history

Commits on Aug 21, 2023

  1. Configuration menu
    Copy the full SHA
    e07791d View commit details
    Browse the repository at this point in the history
  2. Set up EuiTextTruncate component

    TODO: tests
    
    TODO: figure out how to incorporate combobox's search highlighting
    
    TODO: update combobox to dogfood this component
    cee-chen committed Aug 21, 2023
    Configuration menu
    Copy the full SHA
    6131706 View commit details
    Browse the repository at this point in the history
  3. export / rest spread

    cee-chen committed Aug 21, 2023
    Configuration menu
    Copy the full SHA
    ce0bf7e View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    0261f23 View commit details
    Browse the repository at this point in the history
  5. More component cleanup/changes

    - Write prop docs
    
    - Rename `separator` prop to `ellipsis`
    
    - Tweak ellipsis check to return an empty string / not completely throw and simply error instead
    
    - Resize observer - separate to its own component for performance/readability, + tweak conditional to check for `undefined` rather falling back if `0` (may matter for initial render)
    
    - Rename internal `EuiTextTruncateToWidth` to `EuiTextTruncateWithWidth`
    cee-chen committed Aug 21, 2023
    Configuration menu
    Copy the full SHA
    79cb351 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    3f9671f View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    d5d6f3d View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    006eefa View commit details
    Browse the repository at this point in the history

Commits on Aug 22, 2023

  1. [typing] Make truncation prop optional

    since we're already defaulting to `end`
    cee-chen committed Aug 22, 2023
    Configuration menu
    Copy the full SHA
    0c0703c View commit details
    Browse the repository at this point in the history
  2. Rename startEndAnchor to truncationPosition + other cleanup

    - clean up storybook props DX some
    
    - clean up useMemo logic for `truncation` and `truncationOffset` props - prefer moving all logic to a single memo that returns multiple values
    cee-chen committed Aug 22, 2023
    Configuration menu
    Copy the full SHA
    572ce0c View commit details
    Browse the repository at this point in the history
  3. Write tests

    - majority of testing is in Cypress, since JSdom has no concept of dimensions/width
    cee-chen committed Aug 22, 2023
    Configuration menu
    Copy the full SHA
    09cc1c3 View commit details
    Browse the repository at this point in the history
  4. Add docs page and examples for new component

    + fix resizable story to use inline resize on supported browsers
    cee-chen committed Aug 22, 2023
    Configuration menu
    Copy the full SHA
    b45b719 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    17047d1 View commit details
    Browse the repository at this point in the history
  6. Improve screen reader and copy UX

    - at the cost of more repetitive DOM, but I think the tradeoff here is worth it
    cee-chen committed Aug 22, 2023
    Configuration menu
    Copy the full SHA
    1af3b49 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    f46b348 View commit details
    Browse the repository at this point in the history
  8. Add new truncationProps and renderTruncatedOption logic

    - that dogfoods `EuiTextTruncate`
    
    + add support for configuring truncation for all options and individual options
    
    + remove `title` attr, should alreaedy be handled by EuiTextTruncate
    
    + opinionated reordering of imports
    
    + clean up unnecessary `data-test-subj` prop (already inherited from CommonProps)
    
    + remove `OPTION_CONTENT_CLASSNAME` const by always rendering the `__content` wrapper regardless of render method
    cee-chen committed Aug 22, 2023
    Configuration menu
    Copy the full SHA
    8491224 View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    c69441a View commit details
    Browse the repository at this point in the history

Commits on Aug 23, 2023

  1. Configuration menu
    Copy the full SHA
    10dc0e2 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    f219119 View commit details
    Browse the repository at this point in the history
  3. Clean up truncationOffset edge case behavior

    - the new utils allowed me to see how to attempt to continue truncating the logic rather than just metaphorically throwing hands in the air!
    cee-chen committed Aug 23, 2023
    Configuration menu
    Copy the full SHA
    64aaebd View commit details
    Browse the repository at this point in the history
  4. Fix storybook controls

    - `truncationPosition` can't be set back to undefined if it starts as a number
    cee-chen committed Aug 23, 2023
    Configuration menu
    Copy the full SHA
    7d5ce5a View commit details
    Browse the repository at this point in the history
  5. it's hard to word good

    cee-chen committed Aug 23, 2023
    Configuration menu
    Copy the full SHA
    5fd309e View commit details
    Browse the repository at this point in the history
  6. [PR feedback] Expand utilities for to specify DOM vs. canvas render m…

    …ethods
    
    + write more detailed jsdoc comments/descriptions
    
    + add a Cypress spec to confirm canvas util works correctly
    cee-chen committed Aug 23, 2023
    Configuration menu
    Copy the full SHA
    a5837bb View commit details
    Browse the repository at this point in the history
  7. [misc cleanup] fix truncateStart typing

    - param should be optional
    cee-chen committed Aug 23, 2023
    Configuration menu
    Copy the full SHA
    767a44e View commit details
    Browse the repository at this point in the history
  8. Naming things is hard

    cee-chen committed Aug 23, 2023
    Configuration menu
    Copy the full SHA
    4cd6ad5 View commit details
    Browse the repository at this point in the history

Commits on Aug 24, 2023

  1. Fix CI font issues again :|

    - apparently has zero fonts in common with my machine, so google fonts it is
    
    + clean up previous font loading code - we only need 1 weight, and we can use `before()` instead of a mount util
    cee-chen committed Aug 24, 2023
    Configuration menu
    Copy the full SHA
    85ccc1c View commit details
    Browse the repository at this point in the history
  2. [PR feedback] Improve perf of DOM measurement

    + harden standalone behavior
    cee-chen committed Aug 24, 2023
    Configuration menu
    Copy the full SHA
    a1c487d View commit details
    Browse the repository at this point in the history
  3. Update EuiTextTruncate to support using TruncationUtilsForCanvas

    + re-add the font computation method Marco originally had in the canvas class, and require passing in either a font string or a container to compute fonts from
    cee-chen committed Aug 24, 2023
    Configuration menu
    Copy the full SHA
    b6b67b0 View commit details
    Browse the repository at this point in the history
  4. Add documentation section and warnings around performance

    + example where the perf differences between various recommended mitigations can be tested
    cee-chen committed Aug 24, 2023
    Configuration menu
    Copy the full SHA
    f4a9af4 View commit details
    Browse the repository at this point in the history
  5. [misc cleanup] improve tests

    - add basic unit test for confirming that the right utils areb eing called
    
    - add missing E2E test for resize observer behavior
    cee-chen committed Aug 24, 2023
    Configuration menu
    Copy the full SHA
    4a96de8 View commit details
    Browse the repository at this point in the history

Commits on Aug 25, 2023

  1. Configuration menu
    Copy the full SHA
    879b38e View commit details
    Browse the repository at this point in the history
  2. Minor test cleanup

    - remove truncation error testing from the main component - we're already testing that in the utils unit tests
    
    - reorganize utils E2E tests slightly for readability
    
    - misc wording fixes
    cee-chen committed Aug 25, 2023
    Configuration menu
    Copy the full SHA
    30196af View commit details
    Browse the repository at this point in the history

Commits on Sep 1, 2023

  1. Configuration menu
    Copy the full SHA
    6718b37 View commit details
    Browse the repository at this point in the history
  2. changelog

    cee-chen committed Sep 1, 2023
    Configuration menu
    Copy the full SHA
    5098c4c View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    3cb8c0d View commit details
    Browse the repository at this point in the history

Commits on Sep 18, 2023

  1. Configuration menu
    Copy the full SHA
    e28a66e View commit details
    Browse the repository at this point in the history
  2. Add tests

    cee-chen committed Sep 18, 2023
    Configuration menu
    Copy the full SHA
    998ecb1 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    d188bb5 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    b971297 View commit details
    Browse the repository at this point in the history