Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[EuiDescriptionList] Update display to grid for vertical column option with new props #7062
[EuiDescriptionList] Update display to grid for vertical column option with new props #7062
Changes from 5 commits
58ab7cc
1fd6bbd
040cf19
9d46054
28ef754
d64db92
c53c8a8
9bd8385
94c5f68
672f564
0ee59c5
b25bc8f
64e192c
c0c9e1f
3896845
f160fc9
8f2c8ef
fd1e4f7
79cc572
8a59812
db9e57a
dde01e8
f8faa78
c11b79f
2bd11ee
d35e84e
1028d81
2c7e070
507139a
fc12fe6
4ec06df
a38d4c4
d3d8416
56a791d
5311a63
521b4d7
a78ec7a
3e1ad21
0f462d5
7388ea2
0624a3c
95641d0
06ba99a
3e4d1f1
e4669e5
c1f74d3
5710c75
2b6a0cb
3f49cad
eae95f4
024eb73
4808e81
0f4bed3
66354b7
a1ffc4b
a7a5f7c
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, I just noticed this - changing a default prop that affects end users / how components visually display would be considered a breaking change. We'll need to add a changelog item that notes that
EuiDescriptionList
now defaults to a gutter size ofs
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On the subject of breaking changes - the new
max-width
applied to the title would also be considered a visually breaking change, hence why I think I'd lean towards making that a new customizable prop as well.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd rather wait to see whether teams request this. I would want to avoid having situations where a
max-inline-size
gets abused.