Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Emotion][Theming] Add new consumer-configurable font.defaultUnits token #7133

Merged
merged 8 commits into from
Aug 29, 2023
Merged

[Emotion][Theming] Add new consumer-configurable font.defaultUnits token #7133

merged 8 commits into from
Aug 29, 2023

Commits on Aug 28, 2023

  1. Add new theme token for allowing consumers to customize the default f… 

    …ont size unit
    @cee-chen
    cee-chen committed Aug 28, 2023
    Configuration menu
    Copy the full SHA
    22e8e98 View commit details
    Browse the repository at this point in the history

  2. Update EUI font size functions to use new unit token as a default 

    + write missing unit tests for existing utilities
    @cee-chen
    cee-chen committed Aug 28, 2023
    Configuration menu
    Copy the full SHA
    79c59a6 View commit details
    Browse the repository at this point in the history

  3. Add section to typography token docs 

    + with example override behavior
    @cee-chen
    cee-chen committed Aug 28, 2023
    Configuration menu
    Copy the full SHA
    6e93f44 View commit details
    Browse the repository at this point in the history

  4. Fix EuiText and EuiMarkdownFormat to use new token default

    @cee-chen
    cee-chen committed Aug 28, 2023
    Configuration menu
    Copy the full SHA
    648e3b2 View commit details
    Browse the repository at this point in the history

  5. changelog

    @cee-chen
    cee-chen committed Aug 28, 2023
    Configuration menu
    Copy the full SHA
    56125c7 View commit details
    Browse the repository at this point in the history

  6. Rename fontSizeUnit to defaultUnits

    @cee-chen
    cee-chen committed Aug 28, 2023
    Configuration menu
    Copy the full SHA
    c94844c View commit details
    Browse the repository at this point in the history

  7. [!! opinionated change] Rename all measurement related types and va… 

    …riables to `unit` instead

- this feels like a far more understandable nomenclature that native CSS already uses

- it's technically a breaking change, but I'm not even sure who's using these types or utilities, so tbh I'm more inclined to file it under our Emotion header
    @cee-chen
    cee-chen committed Aug 28, 2023
    Configuration menu
    Copy the full SHA
    7d3c34a View commit details
    Browse the repository at this point in the history

Commits on Aug 29, 2023

  1. quick last copy tweak

    @cee-chen
    cee-chen committed Aug 29, 2023
    Configuration menu
    Copy the full SHA
    52e5f90 View commit details
    Browse the repository at this point in the history