Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[EuiInMemoryTable] Allow consumers to use non-EQL plain text search with special characters #7175

Merged
merged 9 commits into from
Sep 18, 2023
Merged

[EuiInMemoryTable] Allow consumers to use non-EQL plain text search with special characters #7175

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
463a854
[setup] move unused `SchemaType` export to main `EuiSearchBar`
cee-chen Sep 8, 2023
ff7f6ed
[tech debt] Convert `EuiSearchBox` to function component + i18n text
cee-chen Sep 8, 2023
65e5205
Add new `plainTextSearch` prop that allows consumers to treat user se…
cee-chen Sep 9, 2023
bf1235e
Fix test errors w/ non-HTML attributes being passed via `...rest`
cee-chen Sep 9, 2023
74f96cc
Add documentation toggle for searching plain text/special characters
cee-chen Sep 9, 2023
4d8fd29
changelog
cee-chen Sep 9, 2023
17d31b5
Merge branch 'main' into memory-table-plaintext-search
cee-chen Sep 15, 2023
feb7a91
[PR feedback] Change `searchPlainText` prop name to `searchFormat`
cee-chen Sep 15, 2023
40d2ea3
Fix broken backslash search :tada:
cee-chen Sep 15, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion src/components/basic_table/in_memory_table.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -551,10 +551,13 @@ export class EuiInMemoryTable<T> extends Component<
let searchBar: ReactNode;

if (searchPlainText) {
const _searchBoxProps = (search as EuiSearchBarProps)?.box || {}; // Work around | boolean type
const { schema, ...searchBoxProps } = _searchBoxProps; // Destructure `schema` so it doesn't get rendered to DOM
cee-chen marked this conversation as resolved.
Show resolved Hide resolved

searchBar = (
<EuiSearchBox
query="" // Unused, passed to satisfy Typescript
{...(search as EuiSearchBarProps)?.box}
{...searchBoxProps}
onSearch={this.onPlainTextSearch}
/>
);
Expand Down Expand Up @@ -692,6 +695,7 @@ export class EuiInMemoryTable<T> extends Component<
tableLayout,
items: _unuseditems,
search,
searchPlainText,
onTableChange,
executeQueryOptions,
allowNeutralSort,
Expand Down