[tech debt] Address faker deprecation warnings #7216
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cee-chen
added
documentation
cee-chen
changed the title
cee-chen
changed the title
|
Preview staging links for this PR:
|
💚 Build Succeeded
|
|
@1Copenut it looks like you hit comment instead of approve 😅 |
|
Haha, thanks! And no worries, for it is friday my dudes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When I upgraded faker versions in #7175 (to generate random special characters), little did I know I was actually spamming us all with a million faker deprecation warnings 💀
Thankfully their jsdoc-fu is super good so I was able to update all APIs to their new names/syntaxes without even having to open their docs 👏
QA
yarn startand look at dev console and confirm there are no longer any faker warnings being emittedGeneral checklist
N/A, internal docs/dev-only