[Tech debt] Fix Jest unit tests to run on React 16 #7237
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cee-chen
reviewed
Sep 29, 2023
cee-chen
reviewed
Sep 29, 2023
|
Fantastic work Trevor! Splitting up the PRs made this much quicker to review/reason about, so I really appreciate that. I have one very minor cleanup request and this PR is good to go. |
|
Preview staging links for this PR:
|
💚 Build Succeeded
History
cc @1Copenut |
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
PR provides script commands to run
.tsand.tsxtests against React[16]with no errors. This PR will be combined with a few others to split our Buildkitetestjob to run in parallel.QA
Remove or strikethrough items that do not apply to your PR.
General checklist
Best way to QA will be to run the following commands after pulling the branch and
yarnto ensure latest dependencies:yarn test-unit --testMatch=non-reactyarn test-unit --react-version=17 --testMatch=reactyarn test-unit --react-version=16 --testMatch=reactyarn test-unit --testMatch=reactyarn test-unitfor a final no-regressions check