Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[EuiSuperDatePicker] Improve Absolute tab input UX further #7341

Merged
merged 7 commits into from
Nov 6, 2023
Merged

[EuiSuperDatePicker] Improve Absolute tab input UX further #7341

merged 7 commits into from
Nov 6, 2023

Commits on Nov 3, 2023

  1. Change UX to parse on Enter key instead of on every keystroke

    @cee-chen
    cee-chen committed Nov 3, 2023
    Configuration menu
    Copy the full SHA
    68a712c View commit details
    Browse the repository at this point in the history

  2. Add an Enter key helptext hint

    @cee-chen
    cee-chen committed Nov 3, 2023
    Configuration menu
    Copy the full SHA
    70f3168 View commit details
    Browse the repository at this point in the history

  3. Fix EuiI18n with multiple tokens not accepting values 

    - not sure why this was never baked in 🤷
    @cee-chen
    cee-chen committed Nov 3, 2023
    Configuration menu
    Copy the full SHA
    c1c5a91 View commit details
    Browse the repository at this point in the history

  4. Minor UX improvement - show formats as helptext 

    + minor CSS hack to preserve visual order when error appears
    @cee-chen
    cee-chen committed Nov 3, 2023
    Configuration menu
    Copy the full SHA
    875e036 View commit details
    Browse the repository at this point in the history

  5. [ft request] Add extra UX affordance for pasting to not require the e… 

    …nter key

requires an early return on `onChange` - onPaste fires before onChange, and onChange will bogart the state updates otherwise
    @cee-chen
    cee-chen committed Nov 3, 2023
    Configuration menu
    Copy the full SHA
    ef71862 View commit details
    Browse the repository at this point in the history

  6. changelog

    @cee-chen
    cee-chen committed Nov 3, 2023
    Configuration menu
    Copy the full SHA
    69de2c7 View commit details
    Browse the repository at this point in the history

  7. [cross browser fix] Webkit state update behavior 

    for some incredibly frustrating reason, firefox correctly runs `finishParsing` after `this.setState` after `onChange` fires, but webkit browsers run it before `onChange`, thus the state shenanigans

and for some even more incredibly bizarre reason, `requestAnimationFrame` works for every browser :dead_inside:
    @cee-chen
    cee-chen committed Nov 3, 2023
    Configuration menu
    Copy the full SHA
    1b6335c View commit details
    Browse the repository at this point in the history