-
Notifications
You must be signed in to change notification settings - Fork 837
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Storybook] Add stories for more components (letter P) - Part 1 #7648
Commits on Apr 3, 2024
-
refactor(storybook): updates utils
- updates internal helper _updateArgTypes to handle multiple control config entries at once + adds additional util enableToggleFunctionControls
Configuration menu - View commit details
-
Copy full SHA for 14f1299 - Browse repository at this point
Copy the full SHA 14f1299View commit details -
docs(storybook): add/update stories
- updates PageHeader story + adds PageHeaderContent and PageTempalte stories - adds type for page directions prop to be reused
Configuration menu - View commit details
-
Copy full SHA for 33dac8d - Browse repository at this point
Copy the full SHA 33dac8dView commit details -
Configuration menu - View commit details
-
Copy full SHA for f01839e - Browse repository at this point
Copy the full SHA f01839eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 4318eb9 - Browse repository at this point
Copy the full SHA 4318eb9View commit details
Commits on Apr 4, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 0425b2d - Browse repository at this point
Copy the full SHA 0425b2dView commit details -
refactor(storybook): improve utils
- updates enableFunctionToggleControls to overwrite global actions behaviour and set a default for function props + add unit tests for enableFunctionToggleControls
Configuration menu - View commit details
-
Copy full SHA for a741710 - Browse repository at this point
Copy the full SHA a741710View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3c8c5d6 - Browse repository at this point
Copy the full SHA 3c8c5d6View commit details
Commits on Apr 5, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 8b704cf - Browse repository at this point
Copy the full SHA 8b704cfView commit details -
- updates restrictWidth control to select = adds additional stories for EuiPageTemplate
Configuration menu - View commit details
-
Copy full SHA for e6f5275 - Browse repository at this point
Copy the full SHA e6f5275View commit details -
Configuration menu - View commit details
-
Copy full SHA for 659e964 - Browse repository at this point
Copy the full SHA 659e964View commit details
Commits on Apr 7, 2024
-
Configuration menu - View commit details
-
Copy full SHA for a3e312d - Browse repository at this point
Copy the full SHA a3e312dView commit details
Commits on Apr 9, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 01892f4 - Browse repository at this point
Copy the full SHA 01892f4View commit details
Commits on Apr 10, 2024
-
- removes skeleton in favor of string to ensure valid HTML + adds parent= on bottom bar to ensure last position on DOM updates
Configuration menu - View commit details
-
Copy full SHA for 256c55c - Browse repository at this point
Copy the full SHA 256c55cView commit details -
Fix child props not correctly updating from
TemplateContext
Turns out the context needed a parent `{}` reference that updates on prop update, which the `useContext()`+setting child properties directly was messing up. Instantiating a new object value via `useMemo` solves the issue + opinionated syntax cleanup while here (use fewer functions - not sure why they needed to be functions??) and destructure more
Configuration menu - View commit details
-
Copy full SHA for 16e3294 - Browse repository at this point
Copy the full SHA 16e3294View commit details -
Configuration menu - View commit details
-
Copy full SHA for 23bce58 - Browse repository at this point
Copy the full SHA 23bce58View commit details -
Refacator
EuiPageTemplate.Sidebar
to use context instead of `react.……cloneElement` - cleaner and matches existing behavior for other subcomponents - consumers who render `<EuiPageTemplate><EuiPageSidebar>` will see broken-ish behavior, but they shouldn't be doing this in any case
Configuration menu - View commit details
-
Copy full SHA for f7d61ce - Browse repository at this point
Copy the full SHA f7d61ceView commit details -
More memoization - children iteration
- not sure how useful this is since `children` is very difficult to memoize on
Configuration menu - View commit details
-
Copy full SHA for 58cc0c4 - Browse repository at this point
Copy the full SHA 58cc0c4View commit details -
Configuration menu - View commit details
-
Copy full SHA for 315abfe - Browse repository at this point
Copy the full SHA 315abfeView commit details
Commits on Apr 11, 2024
-
Configuration menu - View commit details
-
Copy full SHA for ecb2221 - Browse repository at this point
Copy the full SHA ecb2221View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3069f38 - Browse repository at this point
Copy the full SHA 3069f38View commit details