Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Storybook] Add stories for more components (letter P) - Part 1 #7648

Merged
merged 20 commits into from
Apr 11, 2024

Commits on Apr 3, 2024

  1. refactor(storybook): updates utils

    - updates internal helper _updateArgTypes to handle multiple control config entries at once
    
    + adds additional util enableToggleFunctionControls
    mgadewoll committed Apr 3, 2024
    Configuration menu
    Copy the full SHA
    14f1299 View commit details
    Browse the repository at this point in the history
  2. docs(storybook): add/update stories

    - updates PageHeader story
    
    + adds PageHeaderContent and PageTempalte stories
    
    - adds type for page directions prop to be reused
    mgadewoll committed Apr 3, 2024
    Configuration menu
    Copy the full SHA
    33dac8d View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    f01839e View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    4318eb9 View commit details
    Browse the repository at this point in the history

Commits on Apr 4, 2024

  1. Configuration menu
    Copy the full SHA
    0425b2d View commit details
    Browse the repository at this point in the history
  2. refactor(storybook): improve utils

    - updates enableFunctionToggleControls to overwrite global actions behaviour and set a default for function props
    
    + add unit tests for enableFunctionToggleControls
    mgadewoll committed Apr 4, 2024
    Configuration menu
    Copy the full SHA
    a741710 View commit details
    Browse the repository at this point in the history
  3. docs: fix typo

    mgadewoll committed Apr 4, 2024
    Configuration menu
    Copy the full SHA
    3c8c5d6 View commit details
    Browse the repository at this point in the history

Commits on Apr 5, 2024

  1. Configuration menu
    Copy the full SHA
    8b704cf View commit details
    Browse the repository at this point in the history
  2. docs(storybook) PR feedback

    - updates restrictWidth control to select
    
    = adds additional stories for EuiPageTemplate
    mgadewoll committed Apr 5, 2024
    Configuration menu
    Copy the full SHA
    e6f5275 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    659e964 View commit details
    Browse the repository at this point in the history

Commits on Apr 7, 2024

  1. EuiPageTemplate cleanup

    cee-chen committed Apr 7, 2024
    Configuration menu
    Copy the full SHA
    a3e312d View commit details
    Browse the repository at this point in the history

Commits on Apr 9, 2024

  1. Configuration menu
    Copy the full SHA
    01892f4 View commit details
    Browse the repository at this point in the history

Commits on Apr 10, 2024

  1. docs(storybook): PR feedback

    - removes skeleton in favor of string to ensure valid HTML
    
    + adds parent= on bottom bar to ensure last position on DOM updates
    mgadewoll committed Apr 10, 2024
    Configuration menu
    Copy the full SHA
    256c55c View commit details
    Browse the repository at this point in the history
  2. Fix child props not correctly updating from TemplateContext

    Turns out the context needed a parent `{}` reference that updates on prop update, which the `useContext()`+setting child properties directly was messing up. Instantiating a new object value via `useMemo` solves the issue
    
    + opinionated syntax cleanup while here (use fewer functions - not sure why they needed to be functions??) and destructure more
    cee-chen committed Apr 10, 2024
    Configuration menu
    Copy the full SHA
    16e3294 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    23bce58 View commit details
    Browse the repository at this point in the history
  4. Refacator EuiPageTemplate.Sidebar to use context instead of `react.…

    …cloneElement`
    
    - cleaner and matches existing behavior for other subcomponents
    
    - consumers who render `<EuiPageTemplate><EuiPageSidebar>` will see broken-ish behavior, but they shouldn't be doing this in any case
    cee-chen committed Apr 10, 2024
    Configuration menu
    Copy the full SHA
    f7d61ce View commit details
    Browse the repository at this point in the history
  5. More memoization - children iteration

    - not sure how useful this is since `children` is very difficult to memoize on
    cee-chen committed Apr 10, 2024
    Configuration menu
    Copy the full SHA
    58cc0c4 View commit details
    Browse the repository at this point in the history
  6. Fix ternary shenanigans 🤦

    i'm a senior developer errybody
    cee-chen committed Apr 10, 2024
    Configuration menu
    Copy the full SHA
    315abfe View commit details
    Browse the repository at this point in the history

Commits on Apr 11, 2024

  1. changelog

    cee-chen committed Apr 11, 2024
    Configuration menu
    Copy the full SHA
    ecb2221 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    3069f38 View commit details
    Browse the repository at this point in the history