Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Emotion] Convert EuiMarkdownEditor #7738

Merged
merged 17 commits into from
May 7, 2024
Merged

[Emotion] Convert EuiMarkdownEditor #7738

merged 17 commits into from
May 7, 2024

Commits on May 6, 2024

  1. Convert tooltips plugin to use inline Emotion

    @cee-chen
    cee-chen committed May 6, 2024
    Configuration menu
    Copy the full SHA
    3f5cbcf View commit details
    Browse the repository at this point in the history

  2. [EuiMarkdownFormat] Migrate all checkbox styles 

    - remove unnecessary `margin-bottom !important` - doesn't appear to be doing anything whatsoever
    @cee-chen
    cee-chen committed May 6, 2024
    Configuration menu
    Copy the full SHA
    922eb00 View commit details
    Browse the repository at this point in the history

  3. [EuiMarkdownFormat] Convert remaining color styles to Emotion 

    + export new/internal `isNamedColor` util from EuiTextColor
    @cee-chen
    cee-chen committed May 6, 2024
    Configuration menu
    Copy the full SHA
    ad2597a View commit details
    Browse the repository at this point in the history

  4. Clean up markdown checkbox styles 

    - move them from global CSS to the specific plugin/renderer

+ DRY out readonly CSS by moving it to the default checkbox component styles, and setting the actual inputs to `readonly` (which is significantly more accessible to screen readers)
    @cee-chen
    cee-chen committed May 6, 2024
    Configuration menu
    Copy the full SHA
    43eed23 View commit details
    Browse the repository at this point in the history

Commits on May 7, 2024

  1. Convert footer styles

    @cee-chen
    cee-chen committed May 7, 2024
    Configuration menu
    Copy the full SHA
    0129b13 View commit details
    Browse the repository at this point in the history

  2. Convert toolbar styles

    @cee-chen
    cee-chen committed May 7, 2024
    Configuration menu
    Copy the full SHA
    5e90afb View commit details
    Browse the repository at this point in the history

  3. Convert wrapping markdown editor styles 

    + merge amsterdam overrides

+ merge preview styles, doesn't have a separate component

+ start component variables fn
    @cee-chen
    cee-chen committed May 7, 2024
    Configuration menu
    Copy the full SHA
    47873ff View commit details
    Browse the repository at this point in the history

  4. DRY out more component-wide vars

    @cee-chen
    cee-chen committed May 7, 2024
    Configuration menu
    Copy the full SHA
    bcec494 View commit details
    Browse the repository at this point in the history

  5. Convert textarea styles + convert a few needed form utils to Emotion 

    - skip param args in favor of CSS variables (much cleaner all around)

- these utils may need some more cleanup as I move into the actual forms conversions, but they're probably Good Enough for now
    @cee-chen
    cee-chen committed May 7, 2024
    Configuration menu
    Copy the full SHA
    6613613 View commit details
    Browse the repository at this point in the history

  6. Convert dropzone styles to Emotion 

    - look at that CSS variable in action! wowowow

note: I'm skipping reducing nesting specificity and !importants for this component because its ownership is kind of up in the air and it's probably not worth the time right now
    @cee-chen
    cee-chen committed May 7, 2024
    Configuration menu
    Copy the full SHA
    4d2ca45 View commit details
    Browse the repository at this point in the history

  7. Fix bug where dropzone is still active when editor is in read-only mode

    @cee-chen
    cee-chen committed May 7, 2024
    Configuration menu
    Copy the full SHA
    715e308 View commit details
    Browse the repository at this point in the history

  8. Show red invalid line on errors prop presence as well 

    - not sure why this wasn't already the case in prod, so making this opinionated change now
    @cee-chen
    cee-chen committed May 7, 2024
    Configuration menu
    Copy the full SHA
    a77ca5f View commit details
    Browse the repository at this point in the history

  9. Delete remaining Sass files

    @cee-chen
    cee-chen committed May 7, 2024
    Configuration menu
    Copy the full SHA
    e159f02 View commit details
    Browse the repository at this point in the history

  10. [tech debt] Convert all Enzyme tests to RTL 

    + replace an unnecessary snapshot with an assertion
    @cee-chen
    cee-chen committed May 7, 2024
    Configuration menu
    Copy the full SHA
    7f96742 View commit details
    Browse the repository at this point in the history

  11. changelog

    @cee-chen
    cee-chen committed May 7, 2024
    Configuration menu
    Copy the full SHA
    465ba7f View commit details
    Browse the repository at this point in the history

  12. [PR feedback] Fix logical overflow-y

    @cee-chen
    cee-chen committed May 7, 2024
    Configuration menu
    Copy the full SHA
    012f1ec View commit details
    Browse the repository at this point in the history

  13. [PR feedback] gap -> column-gap 

    css is cool y'all
    @cee-chen
    cee-chen committed May 7, 2024
    Configuration menu
    Copy the full SHA
    75c375a View commit details
    Browse the repository at this point in the history