-
Notifications
You must be signed in to change notification settings - Fork 837
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Emotion] Convert EuiCheckbox, EuiRadio, and EuiSwitch #7969
Commits on Aug 18, 2024
-
Convert form style variables to its own utility function
- doesn't need to live in the main form vars fn, these variables are very specific to these components - simplify `customControlDisabledIconColor` to just darkShade - it's close enough and doesn't require extra computation
Configuration menu - View commit details
-
Copy full SHA for 701ba82 - Browse repository at this point
Copy the full SHA 701ba82View commit details -
Replace
@mixin euiIconBackground
inline CSS SVGs with<EuiIcon />
- more future proof for icon changes and generally less CSS - extra DOM is worth it, IMO
Configuration menu - View commit details
-
Copy full SHA for c4e6bc8 - Browse repository at this point
Copy the full SHA c4e6bc8View commit details -
Convert custom control mixins/styles
- remove old Emotion mixin, I'm makin' my own - note the different DOM rendering - now that we have `:has` CSS, we don't need to rely on flat `+` selectors - prefer flex for center alignment over absolute positioning
Configuration menu - View commit details
-
Copy full SHA for e676ad9 - Browse repository at this point
Copy the full SHA e676ad9View commit details -
Remove unnecessary
euiCustomControl
usage in EuiRange- literally just needs `border-radius: 50%` instead
Configuration menu - View commit details
-
Copy full SHA for 6ff66df - Browse repository at this point
Copy the full SHA 6ff66dfView commit details -
[EuiRadio] Convert to use new form util
+ inline conditional label - remove `--noLabel` modifier (replaced with `:has` CSS)
Configuration menu - View commit details
-
Copy full SHA for c716b95 - Browse repository at this point
Copy the full SHA c716b95View commit details -
[EuiCheckbox] Convert base styles
- inline conditional label, remove need for useMemo - inline the border-radius, it's only used here and doesn't need to be a shared var (it technically already is one)
Configuration menu - View commit details
-
Copy full SHA for 7974fc0 - Browse repository at this point
Copy the full SHA 7974fc0View commit details -
[EuiCheckbox] Convert readOnly styles
+ misc cleanup while here - fragment syntax, test syntax
Configuration menu - View commit details
-
Copy full SHA for a64bbf4 - Browse repository at this point
Copy the full SHA a64bbf4View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7dd90d8 - Browse repository at this point
Copy the full SHA 7dd90d8View commit details -
[EuiSwitch] Set up style variables +
mini
size- a lot of colors are being simplified and slightly tweaked here to reduce transparency as well as one-off tinting/shading - remove Sass vars
Configuration menu - View commit details
-
Copy full SHA for f25d657 - Browse repository at this point
Copy the full SHA f25d657View commit details -
[EuiSwitch] Convert wrapper/label styles
- remove unnecessary min-height
Configuration menu - View commit details
-
Copy full SHA for 75b586e - Browse repository at this point
Copy the full SHA 75b586eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 02ce820 - Browse repository at this point
Copy the full SHA 02ce820View commit details -
[opinionated] extra disabled light mode tweaking
- not sure if this is worth it, may revert
Configuration menu - View commit details
-
Copy full SHA for 20ee48a - Browse repository at this point
Copy the full SHA 20ee48aView commit details -
[EuiSwitch] Convert thumb styles
- move thumb to outside body since it has `overflow: hidden` and we want thumbs to be able to scale outside - use `aspect-ratio` CSS instead of static width/height that changes (instead inherits from the button which is already sized) - simplify `-1px` shenanigans by reducing transforms by default, store in thumbScales var + tweak hover/active states accordingly and DRY out a util for it
Configuration menu - View commit details
-
Copy full SHA for eaea656 - Browse repository at this point
Copy the full SHA eaea656View commit details -
Configuration menu - View commit details
-
Copy full SHA for db328c0 - Browse repository at this point
Copy the full SHA db328c0View commit details -
[EuiSwitch] Convert check/cross icon styles
- simplify DOM - rename `__track` to `__icons`, feels more accurate - prefer flex and padding to center/position icons instead of positioning - no need for border-radius, `__body` already has it set + overflow hidden
Configuration menu - View commit details
-
Copy full SHA for 2fb2811 - Browse repository at this point
Copy the full SHA 2fb2811View commit details -
[EuiSwitch] Update snapshots & screenshots
+ update VRT to be more useful for permutation testing
Configuration menu - View commit details
-
Copy full SHA for 1aa72ab - Browse repository at this point
Copy the full SHA 1aa72abView commit details
Commits on Aug 19, 2024
-
[EuiSwitch] Update downstream snapshots/usages
+ fix broken EuiDataGrid drag/drop behavior - we can't use the scroll shadow transform Z workaround and drag/drop at the same time 🫠
Configuration menu - View commit details
-
Copy full SHA for 3df9000 - Browse repository at this point
Copy the full SHA 3df9000View commit details -
Configuration menu - View commit details
-
Copy full SHA for c48491f - Browse repository at this point
Copy the full SHA c48491fView commit details -
[TEMP] Comment out Sass var usage
- will no longer be a thing once the EuiFormRow PR merges, drop this commit then
Configuration menu - View commit details
-
Copy full SHA for 3d407a7 - Browse repository at this point
Copy the full SHA 3d407a7View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0795d3e - Browse repository at this point
Copy the full SHA 0795d3eView commit details -
[PR feedback] Fix focus outline for webkit browsers
- Chrome/Edge's auto style defaults to currentColor which is the empty shade, so its invisible - Safari's is just godawful
Configuration menu - View commit details
-
Copy full SHA for 5abd42a - Browse repository at this point
Copy the full SHA 5abd42aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 7cbbbb1 - Browse repository at this point
Copy the full SHA 7cbbbb1View commit details -
Configuration menu - View commit details
-
Copy full SHA for cd8b659 - Browse repository at this point
Copy the full SHA cd8b659View commit details