Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-add more of a README to packages/eui/ #8058

Merged
merged 2 commits into from
Oct 7, 2024
Merged

Conversation

cee-chen
Copy link
Member

@cee-chen cee-chen commented Oct 2, 2024

Summary

I pruned the duplicate READMEs in #8029 (between / and /packages/eui/ without realizing that /packages/eui/ is what determines what renders in https://www.npmjs.com/package/@elastic/eui, so we now have a very sad looking NPM package 🤦

I've brought back some of the higher level content with links without going so far as to duplicate the FAQ and more detailed docs/copy from the root README.

QA

General checklist

N/A, internal only

@cee-chen cee-chen added documentation Issues or PRs that only affect documentation - will not need changelog entries skip-changelog labels Oct 2, 2024
@cee-chen cee-chen marked this pull request as ready for review October 2, 2024 18:47
@cee-chen cee-chen requested a review from a team as a code owner October 2, 2024 18:48
@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

Copy link
Member

@tkajtoch tkajtoch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

happened to me before too! LGTM

@cee-chen cee-chen merged commit d795367 into elastic:main Oct 7, 2024
6 checks passed
@cee-chen cee-chen deleted the readme branch October 7, 2024 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Issues or PRs that only affect documentation - will not need changelog entries skip-changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants