[Cypress] Add static colorMode for test environment #8066
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- ensures that tests always run in LIGHT mode independent of system setting
cee-chen
reviewed
Oct 9, 2024
💚 Build Succeeded
History
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
In this previous PR we removed the default
colorModeon EuiProvider in favor of listening to system settings.This causes issues in testing environments because our tests assert on LIGHT mode (e.g. color values). Tests will fail when the system setting is set to DARK mode because of this.
Changes
colorMode="light"on the wrapping EuiProvider for cypress testsQA
yarn test-cypress-devand run the test fordata_grid_cell.styles.spec.ts