Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EuiDataGrid] Vertically center toolbar additionalControls items #8085

Merged
merged 2 commits into from
Oct 18, 2024

Conversation

janmonschke
Copy link
Contributor

@janmonschke janmonschke commented Oct 18, 2024

Summary

I recently noticed that the alerts table toolbar in security has items that were not vertically centered. I created fixes for that in Kibana but I think the actual fix would be to add align-items: center; to the actual wrapper classes, hence this PR. [Kibana PR]

Alerts table before:

Screenshot 2024-10-18 at 09 47 53

Alerts table after:

Screenshot 2024-10-18 at 09 47 14

TODO:

@cee-chen
Copy link
Member

cee-chen commented Oct 18, 2024

I think my only hesitation is this might affect other data grids in Kibana that have custom toolbar items that prefer top alignment - I'm not sure what those cases might be, but I'm also don't have every Kibana datagrid memorized 😅 I took a quick peek at Discover and Lens and those look like they should be fine, so I'm good with moving forward with this, but we should add a changelog for this to surface it to consumers just in case. I'll add one here shortly

Copy link
Member

@cee-chen cee-chen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🫶 Thank you for this contribution to EUI Jan! It's super appreciated!

@cee-chen cee-chen enabled auto-merge (squash) October 18, 2024 16:00
@cee-chen cee-chen changed the title [DataGrid] Vertically center toolbar items [EuiDataGrid] Vertically center toolbar additionalControls items Oct 18, 2024
@cee-chen cee-chen enabled auto-merge (squash) October 18, 2024 16:01
@kibanamachine
Copy link

Preview staging links for this PR:

@cee-chen cee-chen merged commit 86a1f4b into elastic:main Oct 18, 2024
5 checks passed
@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

History

@janmonschke
Copy link
Contributor Author

@cee-chen thanks for adding the changelog and reviewing this PR so swiftly :)

@janmonschke
Copy link
Contributor Author

@cee-chen Is there an epic or sth similar that I could follow to get notified about the next EUI release?

@cee-chen
Copy link
Member

No epic, but generally EUI changes will reach Kibana in 1-2 weeks. You can peek at the EUI tag in Kibana. We're going to do another release for the currently in-draft PR so it's likely this change will reach Kibana by end of next Friday.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants