-
Notifications
You must be signed in to change notification settings - Fork 837
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[EuiDataGrid] Vertically center toolbar additionalControls
items
#8085
[EuiDataGrid] Vertically center toolbar additionalControls
items
#8085
Conversation
I think my only hesitation is this might affect other data grids in Kibana that have custom toolbar items that prefer top alignment - I'm not sure what those cases might be, but I'm also don't have every Kibana datagrid memorized 😅 I took a quick peek at Discover and Lens and those look like they should be fine, so I'm good with moving forward with this, but we should add a changelog for this to surface it to consumers just in case. I'll add one here shortly |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🫶 Thank you for this contribution to EUI Jan! It's super appreciated!
additionalControls
items
Preview staging links for this PR:
|
💚 Build Succeeded
History
|
@cee-chen thanks for adding the changelog and reviewing this PR so swiftly :) |
@cee-chen Is there an epic or sth similar that I could follow to get notified about the next EUI release? |
No epic, but generally EUI changes will reach Kibana in 1-2 weeks. You can peek at the EUI tag in Kibana. We're going to do another release for the currently in-draft PR so it's likely this change will reach Kibana by end of next Friday. |
Summary
I recently noticed that the alerts table toolbar in security has items that were not vertically centered. I created fixes for that in Kibana but I think the actual fix would be to add
align-items: center;
to the actual wrapper classes, hence this PR. [Kibana PR]Alerts table before:
Alerts table after:
TODO: