Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

organize (dev|peer)dependencies #824

Merged

Conversation

chandlerprall
Copy link
Contributor

Fixes #672 by moving some of the current dependencies into devDependencies. Also added react-dom to peerDependencies.

Copy link
Contributor

@cjcenizal cjcenizal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🍧 LGTM, just had one suggestion.

package.json Outdated
@@ -35,23 +35,19 @@
"brace": "^0.10.0",
"classnames": "^2.2.5",
"core-js": "^2.5.1",
"eslint-config-prettier": "^2.9.0",
"eslint-plugin-prettier": "^2.6.0",
"focus-trap-react": "^3.0.4",
"highlight.js": "^9.12.0",
"html": "^1.0.0",
"jquery": "^3.2.1",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

jquery is only used by the docs site, so I think we can move this to devDependencies too, right?

@chandlerprall chandlerprall merged commit 8e35ea4 into elastic:master May 14, 2018
@chandlerprall chandlerprall deleted the bug/672-dependency-sorting branch June 1, 2018 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants