return promises

elastic · Nov 9, 2022 · e3ef0c1 · e3ef0c1
1 parent 43c08a1
commit e3ef0c1
Showing 1 changed file with 10 additions and 16 deletions.
diff --git a/kibana/templates/configmap-helm-scripts.yaml b/kibana/templates/configmap-helm-scripts.yaml
@@ -139,40 +139,34 @@ data:
 
           // Create the k8s secret
           console.log('Creating K8S secret');
-          requestPromise(k8sPostSecretUrl, secretCreateOptions, {payload: secretData}).then().catch(err => {
-            console.error(err)
-          });
-          return;
-        })
-      }).catch(err => {
-        console.error(err);
+          requestPromise(k8sPostSecretUrl, secretCreateOptions, {payload: secretData})
+        });
       });
     }
 
     function cleanEsToken() {
       // Chaining requests
       console.log('Cleaning token');
-      requestPromise(esUrl, esTokenDeleteOptions).then(() => {
+      return requestPromise(esUrl, esTokenDeleteOptions).then(() => {
         // Create the k8s secret
         console.log('Delete K8S secret');
-        requestPromise(k8sDeleteSecretUrl, secretDeleteOptions).then().catch(err => {
-          console.error(err)
-        });
-        return;
-      }).catch(err => {
-        console.error(err);
+        requestPromise(k8sDeleteSecretUrl, secretDeleteOptions)
       });
     }
 
     const command = process.argv[2];
     switch (command) {
       case 'create':
         console.log('Creating a new Elasticsearch token for Kibana')
-        createEsToken();
+        createEsToken().catch(err => {
+          console.error(err);
+        });
         break;
       case 'clean':
         console.log('Cleaning the Kibana Elasticsearch token')
-        cleanEsToken();
+        cleanEsToken().catch(err => {
+          console.error(err);
+        });
         break;
       default:
         console.log('Unknown command');