This repository has been archived by the owner on May 16, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
[logstash] using https to connect to elasticsearch #1623
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmlrt
suggested changes
Mar 17, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR should be rebased after #1624 merge to fix the Certificate for <elasticsearch-master> doesn't match any of the subject alternative names
errors.
jmlrt
added a commit
to jmlrt/helm-charts
that referenced
this pull request
Mar 18, 2022
This also seem to be required to Logstash can reuse the Elasticsearch certificates to connect to Elasticsearch Service. Follow-up of elastic#1624 Required for elastic#1623
jmlrt
added a commit
that referenced
this pull request
Mar 21, 2022
jenkins test this please |
jmlrt
reviewed
Mar 21, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Some spaces added by mistakes to remove
- Let's verify that the next CI test is OK for logstash
The rest LGTM.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will use https to connect into elasticsearch by default