Skip to content
This repository has been archived by the owner on May 16, 2023. It is now read-only.

Add resources to InitContainers #40

Merged
merged 4 commits into from
Jan 25, 2019

Conversation

rendhalver
Copy link

Current init containers don't have resource limits specified so it you are deploying this into a cluster that has a ResourceQuota specified the deploy will fail.

Current init containers don't have resource limits specified so it you are deploying this into a cluster that has a ResourceQuota specified the deploy will fail.
@elasticmachine
Copy link
Collaborator

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

Copy link
Contributor

@Crazybus Crazybus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM apart from the docs and testing changes I suggested.

I'm also making a note to create a contributing guide since I'll probably be repeating these comments on every single PR otherwise.

elasticsearch/Chart.yaml Outdated Show resolved Hide resolved
elasticsearch/templates/statefulset.yaml Show resolved Hide resolved
elasticsearch/values.yaml Show resolved Hide resolved
Pete Brown added 3 commits January 24, 2019 15:05
Document the usage of the initResources variable for setting resources for initContainers
This is updated when new release is pushed out.
Copy link
Contributor

@Crazybus Crazybus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Crazybus
Copy link
Contributor

jenkins test this please

@rendhalver
Copy link
Author

Hooray!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants