Skip to content
This repository has been archived by the owner on May 16, 2023. It is now read-only.

[elasticsearch] Add support for NetworkPolicy. #498

Merged
merged 1 commit into from
Jan 4, 2021

Conversation

desaintmartin
Copy link
Contributor

NetworkPolicy support would be a nice addition to this chart. Here is a implementation proposal, open to discussion, where I strictly separate http and transport ports.

  • Chart version not bumped (the versions are all bumped and released at the same time)
  • README.md updated with any new values or changes
  • Updated template tests in ${CHART}/tests/*.py
  • Updated integration tests in ${CHART}/examples/*/test/goss.yaml

@elasticmachine
Copy link
Collaborator

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

@botelastic
Copy link

botelastic bot commented May 27, 2020

This PR has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. To track this PR (even if closed), please open a corresponding issue if one does not already exist.

@desaintmartin
Copy link
Contributor Author

Up?

@Mykolaichenko
Copy link

Upvoting for NetworkPolicy, @desaintmartin thank you :)

@desaintmartin
Copy link
Contributor Author

I can rebase if you are interested into this feature. ;)

@botelastic
Copy link

botelastic bot commented Sep 24, 2020

This PR has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. To track this PR (even if closed), please open a corresponding issue if one does not already exist.

@desaintmartin
Copy link
Contributor Author

Not stale... Is this PR wanted?

@botelastic botelastic bot removed the triage/stale label Sep 24, 2020
@desaintmartin
Copy link
Contributor Author

cc @jmlrt maybe ?

@jmlrt
Copy link
Member

jmlrt commented Sep 30, 2020

Hi @desaintmartin, thanks for this PR. This is still something that we want to merge but don't have workload for a proper review and tests currently.

Copy link
Member

@jmlrt jmlrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @desaintmartin, sorry for the delay, I finally was able to review it.

This is mostly LGTM.

  • Can you merge rebase on master to fix conflicts?
  • The networkpolicy example may not be required if there is no tests specifics to network policies. we could remove the goss.yaml, but if the examples values are the same as commented example in default values, we may not need this example at all
  • Finally the python tests may need to be formatted using Black to pass CI tests

elasticsearch/examples/networkpolicy/test/goss.yaml Outdated Show resolved Hide resolved
elasticsearch/examples/networkpolicy/Makefile Outdated Show resolved Hide resolved
@desaintmartin
Copy link
Contributor Author

Done! Let's see what the CI says.

@jmlrt
Copy link
Member

jmlrt commented Jan 4, 2021

jenkins test this please

elasticsearch/tests/elasticsearch_test.py Outdated Show resolved Hide resolved
elasticsearch/examples/networkpolicy/Makefile Outdated Show resolved Hide resolved
@cla-checker-service
Copy link

cla-checker-service bot commented Jan 4, 2021

💚 CLA has been signed

@desaintmartin
Copy link
Contributor Author

Updated!

@jmlrt
Copy link
Member

jmlrt commented Jan 4, 2021

jenkins test this please

Copy link
Member

@jmlrt jmlrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM⛴

@jmlrt jmlrt merged commit 078f59b into elastic:master Jan 4, 2021
@jmlrt jmlrt added v6.8.14 and removed v6.8.15 labels Jan 12, 2021
jmlrt pushed a commit that referenced this pull request Jan 12, 2021
jmlrt pushed a commit that referenced this pull request Jan 12, 2021
@jmlrt jmlrt changed the title Add support for NetworkPolicy. [elasticsearch] Add support for NetworkPolicy. Jan 27, 2021
@jmlrt jmlrt mentioned this pull request Feb 8, 2021
This was referenced Feb 12, 2021
@jmlrt jmlrt mentioned this pull request Feb 18, 2021
This was referenced Mar 15, 2021
@jmlrt jmlrt mentioned this pull request May 25, 2021
@jmlrt jmlrt mentioned this pull request Mar 8, 2022
@jmlrt jmlrt mentioned this pull request Apr 21, 2022
This was referenced Sep 14, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants