Skip to content
This repository has been archived by the owner on May 16, 2023. It is now read-only.

[elasticsearch][kibana] Add flexible ingress #994

Merged
merged 4 commits into from
Dec 22, 2020

Conversation

kevinsmithwrs
Copy link
Contributor

@kevinsmithwrs kevinsmithwrs commented Dec 18, 2020

  • Chart version not bumped (the versions are all bumped and released at the same time)
  • README.md updated with any new values or changes
  • Updated template tests in ${CHART}/tests/*.py
  • Updated integration tests in ${CHART}/examples/*/test/goss.yaml

Fix #979

@elasticmachine
Copy link
Collaborator

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

@cla-checker-service
Copy link

cla-checker-service bot commented Dec 18, 2020

💚 CLA has been signed

@jmlrt
Copy link
Member

jmlrt commented Dec 21, 2020

cla/check

@jmlrt
Copy link
Member

jmlrt commented Dec 21, 2020

jenkins test this please

Co-authored-by: Julien Mailleret <8582351+jmlrt@users.noreply.github.com>
@jmlrt
Copy link
Member

jmlrt commented Dec 21, 2020

jenkins test this please

Copy link
Member

@jmlrt jmlrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but we need to keep backward compatibility => added in ae0d168

@jmlrt
Copy link
Member

jmlrt commented Dec 22, 2020

jenkins test this please

@jmlrt jmlrt changed the title Add flexible ingress for elasticsearch and kibana [elasticsearch][kibana] Add flexible ingress Dec 22, 2020
@jmlrt jmlrt merged commit 1e07f19 into elastic:master Dec 22, 2020
jmlrt added a commit that referenced this pull request Jan 12, 2021
Co-authored-by: Julien Mailleret <8582351+jmlrt@users.noreply.github.com>
jmlrt added a commit that referenced this pull request Jan 12, 2021
Co-authored-by: Julien Mailleret <8582351+jmlrt@users.noreply.github.com>
@jmlrt jmlrt mentioned this pull request Feb 8, 2021
This was referenced Feb 12, 2021
@jmlrt jmlrt mentioned this pull request Feb 18, 2021
@yurrriq
Copy link

yurrriq commented Feb 26, 2021

LGTM but we need to keep backward compatibility

With no changes to our values, this change broke our Helm release. Is it the case that this chart does not follow semantic versioning? I would have expected a major version bump for this breaking change.

I would also expect the breaking change to be listed here: https://github.com/elastic/helm-charts/blob/master/BREAKING_CHANGES.md#7111

@jmlrt
Copy link
Member

jmlrt commented Mar 1, 2021

Hi @yurrriq,
This change has been updated to ensure backward compatibility.
It shouldn't have any impacts on existing release, that's why we removed the breaking change label.
If you had some issue with this change and your existing values, it's a bug.
Can you open a new ticket and provides all details required so we can investigate?

@yurrriq
Copy link

yurrriq commented Mar 3, 2021

This change has been updated to ensure backward compatibility.

Unfortunately, that is not the case. The breaking change is here, where the schema for ingress.hosts was changed dramatically.

@yurrriq
Copy link

yurrriq commented Mar 3, 2021

I have created #1090

This was referenced Mar 15, 2021
@jmlrt jmlrt mentioned this pull request May 25, 2021
@jmlrt jmlrt mentioned this pull request Mar 8, 2022
@jmlrt jmlrt mentioned this pull request Apr 21, 2022
This was referenced Sep 14, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

elasticsearch multiple ingress rules.
4 participants