Skip to content

Commit

Permalink
APM Service Map popover fixes round 2 (#56911)
Browse files Browse the repository at this point in the history
* Position the popover offscreen when no node is selected
* Unselect all the nodes when setting the selected node to undefined
  • Loading branch information
smith authored Feb 6, 2020
1 parent 1fa01a7 commit 10f48db
Showing 1 changed file with 7 additions and 4 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -26,12 +26,15 @@ export function Popover({ focusedServiceName }: PopoverProps) {
const [selectedNode, setSelectedNode] = useState<
cytoscape.NodeSingular | undefined
>(undefined);
const deselect = useCallback(() => setSelectedNode(undefined), [
setSelectedNode
]);
const deselect = useCallback(() => {
if (cy) {
cy.elements().unselect();
}
setSelectedNode(undefined);
}, [cy, setSelectedNode]);
const renderedHeight = selectedNode?.renderedHeight() ?? 0;
const renderedWidth = selectedNode?.renderedWidth() ?? 0;
const { x, y } = selectedNode?.renderedPosition() ?? { x: 0, y: 0 };
const { x, y } = selectedNode?.renderedPosition() ?? { x: -10000, y: -10000 };
const isOpen = !!selectedNode;
const isService = selectedNode?.data('type') === 'service';
const triggerStyle: CSSProperties = {
Expand Down

0 comments on commit 10f48db

Please sign in to comment.