Skip to content

Commit

Permalink
Revert "adds new test (#60064) (#60268)"
Browse files Browse the repository at this point in the history
This reverts commit 0500350.
  • Loading branch information
spalger committed Mar 16, 2020
1 parent 8243e5c commit 12ed61c
Show file tree
Hide file tree
Showing 3 changed files with 2 additions and 52 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -5,14 +5,12 @@
*/
import {
NUMBER_OF_SIGNALS,
OPEN_CLOSE_SIGNALS_BTN,
SELECTED_SIGNALS,
SHOWING_SIGNALS,
SIGNALS,
} from '../screens/detections';

import {
closeFirstSignal,
closeSignals,
goToClosedSignals,
goToOpenedSignals,
Expand All @@ -28,7 +26,7 @@ import { loginAndWaitForPage } from '../tasks/login';
import { DETECTIONS } from '../urls/navigation';

describe('Detections', () => {
beforeEach(() => {
before(() => {
esArchiverLoad('signals');
loginAndWaitForPage(DETECTIONS);
});
Expand Down Expand Up @@ -113,43 +111,4 @@ describe('Detections', () => {
.should('eql', expectedNumberOfOpenedSignals.toString());
});
});

it('Closes one signal when more than one opened signals are selected', () => {
waitForSignalsToBeLoaded();

cy.get(NUMBER_OF_SIGNALS)
.invoke('text')
.then(numberOfSignals => {
const numberOfSignalsToBeClosed = 1;
const numberOfSignalsToBeSelected = 3;

cy.get(OPEN_CLOSE_SIGNALS_BTN).should('have.attr', 'disabled');
selectNumberOfSignals(numberOfSignalsToBeSelected);
cy.get(OPEN_CLOSE_SIGNALS_BTN).should('not.have.attr', 'disabled');

closeFirstSignal();
cy.reload();
waitForSignalsToBeLoaded();
waitForSignals();

const expectedNumberOfSignals = +numberOfSignals - numberOfSignalsToBeClosed;
cy.get(NUMBER_OF_SIGNALS)
.invoke('text')
.should('eq', expectedNumberOfSignals.toString());
cy.get(SHOWING_SIGNALS)
.invoke('text')
.should('eql', `Showing ${expectedNumberOfSignals.toString()} signals`);

goToClosedSignals();
waitForSignals();

cy.get(NUMBER_OF_SIGNALS)
.invoke('text')
.should('eql', numberOfSignalsToBeClosed.toString());
cy.get(SHOWING_SIGNALS)
.invoke('text')
.should('eql', `Showing ${numberOfSignalsToBeClosed.toString()} signal`);
cy.get(SIGNALS).should('have.length', numberOfSignalsToBeClosed);
});
});
});
4 changes: 1 addition & 3 deletions x-pack/legacy/plugins/siem/cypress/screens/detections.ts
Original file line number Diff line number Diff line change
Expand Up @@ -12,9 +12,7 @@ export const MANAGE_SIGNAL_DETECTION_RULES_BTN = '[data-test-subj="manage-signal

export const NUMBER_OF_SIGNALS = '[data-test-subj="server-side-event-count"]';

export const OPEN_CLOSE_SIGNAL_BTN = '[data-test-subj="update-signal-status-button"]';

export const OPEN_CLOSE_SIGNALS_BTN = '[data-test-subj="openCloseSignal"] button';
export const OPEN_CLOSE_SIGNALS_BTN = '[data-test-subj="openCloseSignal"] .siemLinkIcon__label';

export const OPENED_SIGNALS_BTN = '[data-test-subj="openSignals"]';

Expand Down
7 changes: 0 additions & 7 deletions x-pack/legacy/plugins/siem/cypress/tasks/detections.ts
Original file line number Diff line number Diff line change
Expand Up @@ -8,20 +8,13 @@ import {
CLOSED_SIGNALS_BTN,
LOADING_SIGNALS_PANEL,
MANAGE_SIGNAL_DETECTION_RULES_BTN,
OPEN_CLOSE_SIGNAL_BTN,
OPEN_CLOSE_SIGNALS_BTN,
OPENED_SIGNALS_BTN,
SIGNALS,
SIGNAL_CHECKBOX,
} from '../screens/detections';
import { REFRESH_BUTTON } from '../screens/siem_header';

export const closeFirstSignal = () => {
cy.get(OPEN_CLOSE_SIGNAL_BTN)
.first()
.click({ force: true });
};

export const closeSignals = () => {
cy.get(OPEN_CLOSE_SIGNALS_BTN).click({ force: true });
};
Expand Down

0 comments on commit 12ed61c

Please sign in to comment.