Skip to content

Commit

Permalink
Fix typos in @kbn/handlebars package (#146385)
Browse files Browse the repository at this point in the history
As a follow up to #146174 here's a PR containing the typo-fixes found by
@azasypkin.
  • Loading branch information
Thomas Watson authored Nov 28, 2022
1 parent 1cb49bb commit 185993c
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 4 deletions.
6 changes: 3 additions & 3 deletions packages/kbn-handlebars/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ The tests for `@kbn/handlebars` are integrated into the regular test suite of Ki
node scripts/jest packages/kbn-handlebars
```

By default each test will run both the original `handlebars` code and the modified `@kbn/handlebars` code to compare if the output of the two are identical. To isolate a test run to just one or the other, you can use the following environment variables:
By default, each test will run both the original `handlebars` code and the modified `@kbn/handlebars` code to compare if the output of the two are identical. To isolate a test run to just one or the other, you can use the following environment variables:

- `EVAL=1` - Set to only run the original `handlebars` implementation that uses `eval`.
- `AST=1` - Set to only run the modified `@kbn/handlebars` implementation that doesn't use `eval`.
Expand All @@ -84,7 +84,7 @@ Some of the tests have been copied from the upstream `handlebars` project and mo

If the script outputs a diff for a given file, it means that this file has been updated.

_Note: that this will look for chanages in the `4.x` branch of the `handlebars.js` repo only. Changes in the `master` branch are ignored._
_Note: that this will look for changes in the `4.x` branch of the `handlebars.js` repo only. Changes in the `master` branch are ignored._

Once all updates have been manually merged with our versions of the files, run the following script to "lock" us into the new updates:

Expand Down Expand Up @@ -196,4 +196,4 @@ You can pretty print just the generated code using this command:
node -e 'process.stdin.on(`data`, c => console.log(`(${eval(`(${c})`).code})`))' | \
npx prettier --write --stdin-filepath template.js | \
npx cli-highlight -l javascript
```
```
Original file line number Diff line number Diff line change
Expand Up @@ -276,7 +276,7 @@ describe('builtin helpers', () => {
// TODO: This test has been added to the `4.x` branch of the handlebars.js repo along with a code-fix,
// but a new version of the handlebars package containing this fix has not yet been published to npm.
//
// Before enabling this code, a new version of handlebars needs to be released and the corrosponding
// Before enabling this code, a new version of handlebars needs to be released and the corresponding
// updates needs to be applied to this implementation.
//
// See: https://github.com/handlebars-lang/handlebars.js/commit/30dbf0478109ded8f12bb29832135d480c17e367
Expand Down

0 comments on commit 185993c

Please sign in to comment.