Code review feedback

elastic · Apr 27, 2020 · 1c79cc5 · 1c79cc5
1 parent d2df9c0
commit 1c79cc5
Show file tree

Hide file tree

Showing 3 changed files with 2 additions and 4 deletions.
diff --git a/x-pack/plugins/monitoring/public/components/cluster/listing/listing.js b/x-pack/plugins/monitoring/public/components/cluster/listing/listing.js
@@ -235,7 +235,7 @@ const changeCluster = (scope, globalState, kbnUrl, clusterUuid, ccs) => {
     globalState.cluster_uuid = clusterUuid;
     globalState.ccs = ccs;
     globalState.save();
-    kbnUrl.changePath('/overview');
+    kbnUrl.redirect('/overview');
   });
 };
 

diff --git a/x-pack/plugins/monitoring/public/plugin.ts b/x-pack/plugins/monitoring/public/plugin.ts
@@ -25,7 +25,6 @@ import {
   MONITORING_CONFIG_ALERTING_EMAIL_ADDRESS,
   KIBANA_ALERTING_ENABLED,
 } from '../common/constants';
-import { uiRoutes } from './angular/helpers/routes';
 
 export class MonitoringPlugin
   implements Plugin<void, void, MonitoringPluginDependencies, MonitoringPluginDependencies> {
@@ -90,7 +89,6 @@ export class MonitoringPlugin
         const monitoringApp = new AngularApp(deps);
         const removeHistoryListener = params.history.listen(location => {
           if (location.pathname === '' && location.hash === '') {
-            params.history.push({ hash: uiRoutes.redirect?.redirectTo || '/no-data' });
             monitoringApp.applyScope();
           }
         });

diff --git a/x-pack/plugins/monitoring/public/views/cluster/listing/index.js b/x-pack/plugins/monitoring/public/views/cluster/listing/index.js
@@ -32,7 +32,7 @@ uiRoutes
           }
           if (clusters.length === 1) {
             // Bypass the cluster listing if there is just 1 cluster
-            kbnUrl.changePath('/overview');
+            kbnUrl.redirect('/overview');
             return Promise.reject();
           }
           return clusters;