Skip to content

Commit

Permalink
Merge branch 'master' of github.com:elastic/kibana into migrate-new-p…
Browse files Browse the repository at this point in the history
…latform/ui-settings-client
  • Loading branch information
spalger committed Sep 5, 2018
2 parents de78310 + f7fbed3 commit 23ed10e
Show file tree
Hide file tree
Showing 62 changed files with 822 additions and 637 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -179,7 +179,7 @@ VisTypesRegistryProvider.register(MyNewVisType);
[[development-react-visualization-type]]
==== React Visualization Type
React visualization type assumes you are using React as your rendering technology.
Just pass in a React component to `visConfig.template`.
Just pass in a React component to `visConfig.component`.

The visualization will receive `vis`, `appState`, `updateStatus` and `visData` as props.
It also has a `renderComplete` property, which needs to be called once the rendering has completed.
Expand All @@ -197,7 +197,7 @@ const MyNewVisType = (Private) => {
icon: 'my_icon',
description: 'Cool new chart',
visConfig: {
template: ReactComponent
component: ReactComponent
}
});
}
Expand Down
3 changes: 0 additions & 3 deletions src/core_plugins/kibana/public/kibana.js
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,6 @@ import 'ui/agg_types';
import 'ui/timepicker';
import { showAppRedirectNotification } from 'ui/notify';
import 'leaflet';
import { KibanaRootController } from './kibana_root_controller';

routes.enable();

Expand All @@ -68,6 +67,4 @@ routes
redirectTo: `/${chrome.getInjected('kbnDefaultAppId', 'discover')}`
});

chrome.setRootController('kibana', KibanaRootController);

uiModules.get('kibana').run(showAppRedirectNotification);
Original file line number Diff line number Diff line change
Expand Up @@ -124,7 +124,7 @@

/* Without setting this to 0 you will run into a bug where the filter bar modal is hidden under
a tilemap in an iframe: https://github.com/elastic/kibana/issues/16457 */
> visualize {
> .visualize {
height: 100%;
flex: 1 1 auto;
display: flex;
Expand Down Expand Up @@ -419,7 +419,7 @@ a tilemap in an iframe: https://github.com/elastic/kibana/issues/16457 */
flex-basis: 100%;
}

visualize {
.visualize {
.flex-parent();
flex: 1 1 100%;
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -30,10 +30,11 @@ export const createNodeClientInstructions = () => [
textPre:
'Agents are libraries that run inside of your application process.' +
' APM services are created programmatically based on the `serviceName`.' +
' This agent supports Express, Koa, hapi, and custom Node.js.',
' This agent supports a vararity of frameworks but can also be used with your custom stack.',
commands: `// Add this to the VERY top of the first file loaded in your app
var apm = require('elastic-apm-node').start({curlyOpen}
// Set required service name (allowed characters: a-z, A-Z, 0-9, -, _, and space)
// Override service name from package.json
// Allowed characters: a-z, A-Z, 0-9, -, _, and space
serviceName: '',
// Use if APM Server requires a token
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -36,9 +36,9 @@ import afterdatachangeandresizePng from './afterdatachangeandresize.png';
import aftercolorchangePng from './aftercolorchange.png';
import changestartupPng from './changestartup.png';

const manifestUrl = 'https://staging-dot-catalogue-dot-elastic-layer.appspot.com/v1/manifest';
const tmsManifestUrl = `"https://tiles-maps-stage.elastic.co/v2/manifest`;
const vectorManifestUrl = `"https://staging-dot-elastic-layer.appspot.com/v1/manifest`;
const manifestUrl = 'https://catalogue-staging.maps.elastic.co/v2/manifest';
const tmsManifestUrl = `https://tiles-maps-stage.elastic.co/v2/manifest`;
const vectorManifestUrl = `https://vector-staging.maps.elastic.co/v2/manifest`;
const manifest = {
'services': [{
'id': 'tiles_v2',
Expand Down Expand Up @@ -189,7 +189,7 @@ describe('RegionMapsVisualizationTests', function () {
'attribution': '<p><a href="http://www.naturalearthdata.com/about/terms-of-use">Made with NaturalEarth</a> | <a href="https://www.elastic.co/elastic-maps-service">Elastic Maps Service</a></p>&#10;',
'name': 'World Countries',
'format': 'geojson',
'url': 'https://staging-dot-elastic-layer.appspot.com/blob/5715999101812736?elastic_tile_service_tos=agree&my_app_version=7.0.0-alpha1',
'url': 'https://vector-staging.maps.elastic.co/blob/5715999101812736?elastic_tile_service_tos=agree&my_app_version=7.0.0-alpha1',
'fields': [{ 'name': 'iso2', 'description': 'Two letter abbreviation' }, {
'name': 'iso3',
'description': 'Three letter abbreviation'
Expand Down
2 changes: 1 addition & 1 deletion src/core_plugins/tests_bundle/tests_entry_template.js
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ const legacyMetadata = {
},
mapConfig: {
includeElasticMapsService: true,
manifestServiceUrl: 'https://staging-dot-catalogue-dot-elastic-layer.appspot.com/v1/manifest'
manifestServiceUrl: 'https://catalogue-staging.maps.elastic.co/v2/manifest'
},
vegaConfig: {
enabled: true,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ function mockRawData() {
mockRawData();


const manifestUrl = 'https://staging-dot-catalogue-dot-elastic-layer.appspot.com/v1/manifest';
const manifestUrl = 'https://catalogue-staging.maps.elastic.co/v2/manifest';
const tmsManifestUrl = `"https://tiles-maps-stage.elastic.co/v2/manifest`;
const manifest = {
'services': [{
Expand Down
4 changes: 0 additions & 4 deletions src/core_plugins/timelion/public/app.js
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,6 @@
*/

import _ from 'lodash';
import moment from 'moment-timezone';

import { DocTitleProvider } from 'ui/doc_title';
import { SavedObjectRegistryProvider } from 'ui/saved_objects/saved_object_registry';
Expand Down Expand Up @@ -101,9 +100,6 @@ app.controller('timelion', function (
$scope.page = config.get('timelion:showTutorial', true) ? 1 : 0;
$scope.setPage = (page) => $scope.page = page;

// TODO: For some reason the Kibana core doesn't correctly do this for all apps.
moment.tz.setDefault(config.get('dateFormat:tz'));

timefilter.enableAutoRefreshSelector();
timefilter.enableTimeRangeSelector();

Expand Down
31 changes: 0 additions & 31 deletions src/dev/i18n/__snapshots__/extract_code_messages.test.js.snap

This file was deleted.

179 changes: 50 additions & 129 deletions src/dev/i18n/__snapshots__/extract_default_translations.test.js.snap
Original file line number Diff line number Diff line change
@@ -1,142 +1,63 @@
// Jest Snapshot v1, https://goo.gl/fbAQLP

exports[`dev/i18n/extract_default_translations extracts messages to en.json 1`] = `
"{
\\"formats\\": {
\\"number\\": {
\\"currency\\": {
\\"style\\": \\"currency\\"
},
\\"percent\\": {
\\"style\\": \\"percent\\"
}
exports[`dev/i18n/extract_default_translations extracts messages from path to map 1`] = `
Array [
Array [
"plugin_1.id_1",
Object {
"context": undefined,
"message": "Message 1",
},
\\"date\\": {
\\"short\\": {
\\"month\\": \\"numeric\\",
\\"day\\": \\"numeric\\",
\\"year\\": \\"2-digit\\"
},
\\"medium\\": {
\\"month\\": \\"short\\",
\\"day\\": \\"numeric\\",
\\"year\\": \\"numeric\\"
},
\\"long\\": {
\\"month\\": \\"long\\",
\\"day\\": \\"numeric\\",
\\"year\\": \\"numeric\\"
},
\\"full\\": {
\\"weekday\\": \\"long\\",
\\"month\\": \\"long\\",
\\"day\\": \\"numeric\\",
\\"year\\": \\"numeric\\"
}
],
Array [
"plugin_1.id_2",
Object {
"context": "Message context",
"message": "Message 2",
},
\\"time\\": {
\\"short\\": {
\\"hour\\": \\"numeric\\",
\\"minute\\": \\"numeric\\"
},
\\"medium\\": {
\\"hour\\": \\"numeric\\",
\\"minute\\": \\"numeric\\",
\\"second\\": \\"numeric\\"
},
\\"long\\": {
\\"hour\\": \\"numeric\\",
\\"minute\\": \\"numeric\\",
\\"second\\": \\"numeric\\",
\\"timeZoneName\\": \\"short\\"
},
\\"full\\": {
\\"hour\\": \\"numeric\\",
\\"minute\\": \\"numeric\\",
\\"second\\": \\"numeric\\",
\\"timeZoneName\\": \\"short\\"
}
}
},
\\"plugin_1.id_1\\": \\"Message 1\\",
\\"plugin_1.id_2\\": {
\\"text\\": \\"Message 2\\",
\\"comment\\": \\"Message context\\"
},
\\"plugin_1.id_3\\": \\"Message 3\\",
\\"plugin_1.id_4\\": \\"Message 4\\",
\\"plugin_1.id_5\\": \\"Message 5\\",
\\"plugin_1.id_6\\": \\"Message 6\\",
\\"plugin_1.id_7\\": \\"Message 7\\"
}"
`;

exports[`dev/i18n/extract_default_translations injects default formats into en.json 1`] = `
"{
\\"formats\\": {
\\"number\\": {
\\"currency\\": {
\\"style\\": \\"currency\\"
},
\\"percent\\": {
\\"style\\": \\"percent\\"
}
],
Array [
"plugin_1.id_3",
Object {
"context": undefined,
"message": "Message 3",
},
],
Array [
"plugin_1.id_4",
Object {
"context": undefined,
"message": "Message 4",
},
],
Array [
"plugin_1.id_5",
Object {
"context": undefined,
"message": "Message 5",
},
],
Array [
"plugin_1.id_6",
Object {
"context": "",
"message": "Message 6",
},
\\"date\\": {
\\"short\\": {
\\"month\\": \\"numeric\\",
\\"day\\": \\"numeric\\",
\\"year\\": \\"2-digit\\"
},
\\"medium\\": {
\\"month\\": \\"short\\",
\\"day\\": \\"numeric\\",
\\"year\\": \\"numeric\\"
},
\\"long\\": {
\\"month\\": \\"long\\",
\\"day\\": \\"numeric\\",
\\"year\\": \\"numeric\\"
},
\\"full\\": {
\\"weekday\\": \\"long\\",
\\"month\\": \\"long\\",
\\"day\\": \\"numeric\\",
\\"year\\": \\"numeric\\"
}
],
Array [
"plugin_1.id_7",
Object {
"context": undefined,
"message": "Message 7",
},
\\"time\\": {
\\"short\\": {
\\"hour\\": \\"numeric\\",
\\"minute\\": \\"numeric\\"
},
\\"medium\\": {
\\"hour\\": \\"numeric\\",
\\"minute\\": \\"numeric\\",
\\"second\\": \\"numeric\\"
},
\\"long\\": {
\\"hour\\": \\"numeric\\",
\\"minute\\": \\"numeric\\",
\\"second\\": \\"numeric\\",
\\"timeZoneName\\": \\"short\\"
},
\\"full\\": {
\\"hour\\": \\"numeric\\",
\\"minute\\": \\"numeric\\",
\\"second\\": \\"numeric\\",
\\"timeZoneName\\": \\"short\\"
}
}
},
\\"plugin_2.message-id\\": \\"Message text\\"
}"
],
]
`;

exports[`dev/i18n/extract_default_translations throws on id collision 1`] = `
" I18N ERROR  Error in src/dev/i18n/__fixtures__/extract_default_translations/test_plugin_3/test_file.jsx
Error: [37m[41m I18N ERROR [49m[39m There is more than one default message for the same id \\"plugin_3.duplicate_id\\":
Error: There is more than one default message for the same id \\"plugin_3.duplicate_id\\":
\\"Message 1\\" and \\"Message 2\\""
`;

exports[`dev/i18n/extract_default_translations throws on wrong message namespace 1`] = `"[37m[41m I18N ERROR [49m[39m Expected \\"wrong_plugin_namespace.message-id\\" id to have \\"plugin_2\\" namespace. See i18nrc.json for the list of supported namespaces."`;
exports[`dev/i18n/extract_default_translations throws on wrong message namespace 1`] = `"Expected \\"wrong_plugin_namespace.message-id\\" id to have \\"plugin_2\\" namespace. See .i18nrc.json for the list of supported namespaces."`;

This file was deleted.

Loading

0 comments on commit 23ed10e

Please sign in to comment.