Replace Pick<...> with two separate interfaces as it doesn't work wel…

…l with our docs
elastic · Jun 10, 2021 · 2425821 · 2425821
1 parent 9b932dc
commit 2425821
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 4 deletions.
diff --git a/x-pack/plugins/security/public/account_management/change_password/change_password.tsx b/x-pack/plugins/security/public/account_management/change_password/change_password.tsx
@@ -19,11 +19,14 @@ import { ChangePasswordForm } from '../../management/users/components/change_pas
 
 export interface ChangePasswordProps {
   user: AuthenticatedUser;
+}
+
+export interface ChangePasswordPropsInternal extends ChangePasswordProps {
   userAPIClient: PublicMethodsOf<UserAPIClient>;
   notifications: NotificationsSetup;
 }
 
-export class ChangePassword extends Component<ChangePasswordProps, {}> {
+export class ChangePassword extends Component<ChangePasswordPropsInternal, {}> {
   public render() {
     const canChangePassword = canUserChangePassword(this.props.user);
 

diff --git a/x-pack/plugins/security/public/account_management/change_password/change_password_async.tsx b/x-pack/plugins/security/public/account_management/change_password/change_password_async.tsx
@@ -14,10 +14,10 @@ import type { ChangePasswordProps } from './change_password';
 
 export const getChangePasswordComponent = async (
   core: CoreStart
-): Promise<React.FC<Pick<ChangePasswordProps, 'user'>>> => {
+): Promise<React.FC<ChangePasswordProps>> => {
   const { ChangePassword } = await import('./change_password');
 
-  return (props: Pick<ChangePasswordProps, 'user'>) => {
+  return (props: ChangePasswordProps) => {
     return (
       <ChangePassword
         notifications={core.notifications}

diff --git a/x-pack/plugins/security/public/ui_api/index.ts b/x-pack/plugins/security/public/ui_api/index.ts
@@ -21,7 +21,7 @@ type LazyComponentFn<T> = (props: T) => ReactElement;
 export interface UiApi {
   components: {
     getPersonalInfo: LazyComponentFn<PersonalInfoProps>;
-    getChangePassword: LazyComponentFn<Pick<ChangePasswordProps, 'user'>>;
+    getChangePassword: LazyComponentFn<ChangePasswordProps>;
   };
 }