Make slack param validation handle empty messages (#60468)

elastic · Mar 19, 2020 · 27045e0 · 27045e0
1 parent 8fd317c
commit 27045e0
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 1 deletion.
diff --git a/x-pack/plugins/actions/server/builtin_action_types/slack.ts b/x-pack/plugins/actions/server/builtin_action_types/slack.ts
@@ -35,7 +35,7 @@ const SecretsSchema = schema.object(secretsSchemaProps);
 export type ActionParamsType = TypeOf<typeof ParamsSchema>;
 
 const ParamsSchema = schema.object({
-  message: schema.string(),
+  message: schema.string({ minLength: 1 }),
 });
 
 // action type definition

diff --git a/.../alerting_api_integration/security_and_spaces/tests/actions/builtin_action_types/slack.ts b/.../alerting_api_integration/security_and_spaces/tests/actions/builtin_action_types/slack.ts
@@ -159,6 +159,20 @@ export default function slackTest({ getService }: FtrProviderContext) {
       expect(result.status).to.eql('ok');
     });
 
+    it('should handle an empty message error', async () => {
+      const { body: result } = await supertest
+        .post(`/api/action/${simulatedActionId}/_execute`)
+        .set('kbn-xsrf', 'foo')
+        .send({
+          params: {
+            message: '',
+          },
+        })
+        .expect(200);
+      expect(result.status).to.eql('error');
+      expect(result.message).to.match(/error validating action params: \[message\]: /);
+    });
+
     it('should handle a 40x slack error', async () => {
       const { body: result } = await supertest
         .post(`/api/action/${simulatedActionId}/_execute`)