remove true from dynamic property definition, use force-cast back for…

… config type

docs/development/core/server/kibana-plugin-server.authtoolkit.md

@@ -18,5 +18,5 @@ export interface AuthToolkit
 |  --- | --- | --- |
 |  [authenticated](./kibana-plugin-server.authtoolkit.authenticated.md) | <code>(data?: AuthResultParams) =&gt; AuthResult</code> | Authentication is successful with given credentials, allow request to pass through |
 |  [notHandled](./kibana-plugin-server.authtoolkit.nothandled.md) | <code>() =&gt; AuthResult</code> | User has no credentials. Allows user to access a resource when authRequired: 'optional' Rejects a request when authRequired: true |
-|  [redirected](./kibana-plugin-server.authtoolkit.redirected.md) | <code>(headers: {</code><br/><code>        location: string;</code><br/><code>    } &amp; ResponseHeaders) =&gt; AuthResult</code> | Redirect user to IdP when authRequired: true Allows user to access a resource without redirection when authRequired: 'optional' |
+|  [redirected](./kibana-plugin-server.authtoolkit.redirected.md) | <code>(headers: {</code><br/><code>        location: string;</code><br/><code>    } &amp; ResponseHeaders) =&gt; AuthResult</code> | Redirects user to another location to complete authentication when authRequired: true Allows user to access a resource without redirection when authRequired: 'optional' |
 

docs/development/core/server/kibana-plugin-server.authtoolkit.redirected.md

@@ -4,7 +4,7 @@
 
 ## AuthToolkit.redirected property
 
-Redirect user to IdP when authRequired: true Allows user to access a resource without redirection when authRequired: 'optional'
+Redirects user to another location to complete authentication when authRequired: true Allows user to access a resource without redirection when authRequired: 'optional'
 
 <b>Signature:</b>
 

docs/development/core/server/kibana-plugin-server.savedobjectstypemappingdefinition.dynamic.md

@@ -4,10 +4,10 @@
 
 ## SavedObjectsTypeMappingDefinition.dynamic property
 
-The dynamic property of the mapping. either `true`<!-- -->, `false` or 'strict'. Defaults to `false`
+The dynamic property of the mapping. either `false` or 'strict'. Defaults to `false`
 
 <b>Signature:</b>
 
 ```typescript
-dynamic?: boolean | 'strict';
+dynamic?: false | 'strict';
 ```

docs/development/core/server/kibana-plugin-server.savedobjectstypemappingdefinition.md

@@ -41,6 +41,6 @@ const typeDefinition: SavedObjectsTypeMappingDefinition = {
 
 |  Property | Type | Description |
 |  --- | --- | --- |
-|  [dynamic](./kibana-plugin-server.savedobjectstypemappingdefinition.dynamic.md) | <code>boolean &#124; 'strict'</code> | The dynamic property of the mapping. either <code>true</code>, <code>false</code> or 'strict'. Defaults to <code>false</code> |
+|  [dynamic](./kibana-plugin-server.savedobjectstypemappingdefinition.dynamic.md) | <code>false &#124; 'strict'</code> | The dynamic property of the mapping. either <code>false</code> or 'strict'. Defaults to <code>false</code> |
 |  [properties](./kibana-plugin-server.savedobjectstypemappingdefinition.properties.md) | <code>SavedObjectsMappingProperties</code> | The underlying properties of the type mapping |
 

src/core/server/saved_objects/mappings/types.ts

@@ -45,8 +45,8 @@
  * @public
  */
 export interface SavedObjectsTypeMappingDefinition {
-  /** The dynamic property of the mapping. either `true`, `false` or 'strict'. Defaults to `false` */
-  dynamic?: boolean | 'strict';
+  /** The dynamic property of the mapping. either `false` or 'strict'. Defaults to `false` */
+  dynamic?: false | 'strict';
   /** The underlying properties of the type mapping */
   properties: SavedObjectsMappingProperties;
 }

src/core/server/server.api.md

@@ -2173,7 +2173,7 @@ export interface SavedObjectsTypeManagementDefinition {
 
 // @public
 export interface SavedObjectsTypeMappingDefinition {
-    dynamic?: boolean | 'strict';
+    dynamic?: false | 'strict';
     properties: SavedObjectsMappingProperties;
 }
 

src/core/server/ui_settings/saved_objects/ui_settings.ts

@@ -24,7 +24,10 @@ export const uiSettingsType: SavedObjectsType = {
   hidden: false,
   namespaceAgnostic: false,
   mappings: {
-    dynamic: true,
+    // we don't want to allow `true` in the public `SavedObjectsTypeMappingDefinition` type, however
+    // this is needed for the config that is kinda a special type. To avoid adding additional internal types
+    // just for this, we hardcast to any here.
+    dynamic: true as any,
     properties: {
       buildNum: {
         type: 'keyword',