Skip to content

Commit

Permalink
Fix Jest warnings for ConfirmModal. (#14892)
Browse files Browse the repository at this point in the history
  • Loading branch information
cjcenizal authored Nov 10, 2017
1 parent 30238e8 commit 3bde843
Showing 1 changed file with 48 additions and 24 deletions.
72 changes: 48 additions & 24 deletions ui_framework/src/components/modal/confirm_modal.test.js
Original file line number Diff line number Diff line change
Expand Up @@ -34,32 +34,44 @@ test('renders KuiConfirmModal', () => {
});

test('onConfirm', () => {
const component = mount(<KuiConfirmModal
onCancel={onCancel}
onConfirm={onConfirm}
/>);
const component = mount(
<KuiConfirmModal
onCancel={onCancel}
onConfirm={onConfirm}
cancelButtonText="Cancel Button Text"
confirmButtonText="Confirm Button Text"
/>
);
component.find('[data-test-subj="confirmModalConfirmButton"]').simulate('click');
sinon.assert.calledOnce(onConfirm);
sinon.assert.notCalled(onCancel);
});

describe('onCancel', () => {
test('triggerd by click', () => {
const component = mount(<KuiConfirmModal
onCancel={onCancel}
onConfirm={onConfirm}
/>);
const component = mount(
<KuiConfirmModal
onCancel={onCancel}
onConfirm={onConfirm}
cancelButtonText="Cancel Button Text"
confirmButtonText="Confirm Button Text"
/>
);
component.find('[data-test-subj="confirmModalCancelButton"]').simulate('click');
sinon.assert.notCalled(onConfirm);
sinon.assert.calledOnce(onCancel);
});

test('triggered by esc key', () => {
const component = mount(<KuiConfirmModal
onCancel={onCancel}
onConfirm={onConfirm}
data-test-subj="modal"
/>);
const component = mount(
<KuiConfirmModal
onCancel={onCancel}
onConfirm={onConfirm}
cancelButtonText="Cancel Button Text"
confirmButtonText="Confirm Button Text"
data-test-subj="modal"
/>
);
component.find('[data-test-subj="modal"]').simulate('keydown', { keyCode: keyCodes.ESCAPE });
sinon.assert.notCalled(onConfirm);
sinon.assert.calledOnce(onCancel);
Expand All @@ -68,27 +80,39 @@ describe('onCancel', () => {

describe('defaultFocusedButton', () => {
test('is cancel', () => {
const component = mount(<KuiConfirmModal
onCancel={onCancel}
defaultFocusedButton={CANCEL_BUTTON}
/>);
const component = mount(
<KuiConfirmModal
onCancel={onCancel}
defaultFocusedButton={CANCEL_BUTTON}
cancelButtonText="Cancel Button Text"
confirmButtonText="Confirm Button Text"
/>
);
const button = component.find('[data-test-subj="confirmModalCancelButton"]').getDOMNode();
expect(document.activeElement).toEqual(button);
});

test('is confirm', () => {
const component = mount(<KuiConfirmModal
onCancel={onCancel}
defaultFocusedButton={CONFIRM_BUTTON}
/>);
const component = mount(
<KuiConfirmModal
onCancel={onCancel}
defaultFocusedButton={CONFIRM_BUTTON}
cancelButtonText="Cancel Button Text"
confirmButtonText="Confirm Button Text"
/>
);
const button = component.find('[data-test-subj="confirmModalConfirmButton"]').getDOMNode();
expect(document.activeElement).toEqual(button);
});

test('when not given gives focus to the modal', () => {
const component = mount(<KuiConfirmModal
onCancel={onCancel}
/>);
const component = mount(
<KuiConfirmModal
onCancel={onCancel}
cancelButtonText="Cancel Button Text"
confirmButtonText="Confirm Button Text"
/>
);
expect(document.activeElement).toEqual(component.getDOMNode().firstChild);
});
});

0 comments on commit 3bde843

Please sign in to comment.