[ML] Refactor decision path components to under analytics exploration…

…, add important!
elastic · Feb 16, 2021 · 3f76bf8 · 3f76bf8
1 parent 2eee081
commit 3f76bf8
Show file tree

Hide file tree

Showing 11 changed files with 22 additions and 22 deletions.
diff --git a/x-pack/plugins/ml/public/application/components/data_grid/data_grid.scss b/x-pack/plugins/ml/public/application/components/data_grid/data_grid.scss
@@ -3,9 +3,3 @@
     text-transform: none;
   }
 }
-
-// Make sure the charts tooltip in popover
-// have higher zIndex than Eui popover cells
-[id^='echTooltipPortal'] {
-  z-index: 10000;
-}
diff --git a/x-pack/plugins/ml/public/application/components/data_grid/data_grid.tsx b/x-pack/plugins/ml/public/application/components/data_grid/data_grid.tsx
@@ -35,7 +35,7 @@ import {
   getTopClasses,
 } from './common';
 import { UseIndexDataReturnType } from './types';
-import { DecisionPathPopover } from './feature_importance/decision_path_popover';
+import { DecisionPathPopover } from '../../data_frame_analytics/pages/analytics_exploration/components/feature_importance/decision_path_popover';
 import {
   FeatureImportanceBaseline,
   FeatureImportance,

diff --git a/...alytics/pages/analytics_exploration/components/expandable_section/expandable_section.scss b/...alytics/pages/analytics_exploration/components/expandable_section/expandable_section.scss
@@ -5,3 +5,9 @@
 .mlExpandableSection-contentPadding {
   padding: $euiSizeS;
 }
+
+// Make sure the charts tooltip in popover
+// have higher zIndex than Eui popover cells
+[id^='echTooltipPortal'] {
+  z-index: 10000 !important;
+}
diff --git a/...eature_importance/decision_path_chart.tsx → ...eature_importance/decision_path_chart.tsx b/...eature_importance/decision_path_chart.tsx → ...eature_importance/decision_path_chart.tsx
@@ -25,12 +25,12 @@ import { EuiIcon } from '@elastic/eui';
 import React, { useCallback, useMemo } from 'react';
 import { i18n } from '@kbn/i18n';
 import euiVars from '@elastic/eui/dist/eui_theme_light.json';
-import { DecisionPathPlotData } from './use_classification_path_data';
-import { formatSingleValue } from '../../../formatters/format_value';
+import type { DecisionPathPlotData } from './use_classification_path_data';
+import { formatSingleValue } from '../../../../../formatters/format_value';
 import {
   FeatureImportanceBaseline,
   isRegressionFeatureImportanceBaseline,
-} from '../../../../../common/types/feature_importance';
+} from '../../../../../../../common/types/feature_importance';
 const { euiColorFullShade, euiColorMediumShade } = euiVars;
 const axisColor = euiColorMediumShade;
 

diff --git a/...portance/decision_path_classification.tsx → ...portance/decision_path_classification.tsx b/...portance/decision_path_classification.tsx → ...portance/decision_path_classification.tsx
@@ -14,11 +14,11 @@ import {
   useDecisionPathData,
   getStringBasedClassName,
 } from './use_classification_path_data';
-import {
+import type {
   FeatureImportance,
   FeatureImportanceBaseline,
   TopClasses,
-} from '../../../../../common/types/feature_importance';
+} from '../../../../../../../common/types/feature_importance';
 import { DecisionPathChart } from './decision_path_chart';
 import { MissingDecisionPathCallout } from './missing_decision_path_callout';
 

diff --git a/..._importance/decision_path_json_viewer.tsx → ..._importance/decision_path_json_viewer.tsx b/..._importance/decision_path_json_viewer.tsx → ..._importance/decision_path_json_viewer.tsx
@@ -7,7 +7,7 @@
 
 import React, { FC } from 'react';
 import { EuiCodeBlock } from '@elastic/eui';
-import { FeatureImportance } from '../../../../../common/types/feature_importance';
+import type { FeatureImportance } from '../../../../../../../common/types/feature_importance';
 
 interface DecisionPathJSONViewerProps {
   featureImportance: FeatureImportance[];

diff --git a/...ture_importance/decision_path_popover.tsx → ...ture_importance/decision_path_popover.tsx b/...ture_importance/decision_path_popover.tsx → ...ture_importance/decision_path_popover.tsx
@@ -16,11 +16,11 @@ import {
   isClassificationFeatureImportanceBaseline,
   isRegressionFeatureImportanceBaseline,
   TopClasses,
-} from '../../../../../common/types/feature_importance';
-import { ANALYSIS_CONFIG_TYPE } from '../../../data_frame_analytics/common';
+} from '../../../../../../../common/types/feature_importance';
+import { ANALYSIS_CONFIG_TYPE } from '../../../../common';
 import { ClassificationDecisionPath } from './decision_path_classification';
-import { useMlKibana } from '../../../contexts/kibana';
-import { DataFrameAnalysisConfigType } from '../../../../../common/types/data_frame_analytics';
+import { useMlKibana } from '../../../../../contexts/kibana';
+import type { DataFrameAnalysisConfigType } from '../../../../../../../common/types/data_frame_analytics';
 import { getStringBasedClassName } from './use_classification_path_data';
 
 interface DecisionPathPopoverProps {

diff --git a/...e_importance/decision_path_regression.tsx → ...e_importance/decision_path_regression.tsx b/...e_importance/decision_path_regression.tsx → ...e_importance/decision_path_regression.tsx
@@ -9,11 +9,11 @@ import React, { FC, useMemo } from 'react';
 import { EuiCallOut } from '@elastic/eui';
 import { FormattedMessage } from '@kbn/i18n/react';
 import d3 from 'd3';
-import {
+import type {
   FeatureImportance,
   FeatureImportanceBaseline,
   TopClasses,
-} from '../../../../../common/types/feature_importance';
+} from '../../../../../../../common/types/feature_importance';
 import { useDecisionPathData, isDecisionPathData } from './use_classification_path_data';
 import { DecisionPathChart } from './decision_path_chart';
 import { MissingDecisionPathCallout } from './missing_decision_path_callout';

diff --git a/...ortance/missing_decision_path_callout.tsx → ...ortance/missing_decision_path_callout.tsx b/...ortance/missing_decision_path_callout.tsx → ...ortance/missing_decision_path_callout.tsx
diff --git a/...nce/use_classification_path_data.test.tsx → ...nce/use_classification_path_data.test.tsx b/...nce/use_classification_path_data.test.tsx → ...nce/use_classification_path_data.test.tsx
@@ -9,7 +9,7 @@ import {
   buildClassificationDecisionPathData,
   buildRegressionDecisionPathData,
 } from './use_classification_path_data';
-import { FeatureImportance } from '../../../../../common/types/feature_importance';
+import type { FeatureImportance } from '../../../../../../../common/types/feature_importance';
 
 describe('buildClassificationDecisionPathData()', () => {
   test('should return correct prediction probability for binary classification', () => {

diff --git a/...portance/use_classification_path_data.tsx → ...portance/use_classification_path_data.tsx b/...portance/use_classification_path_data.tsx → ...portance/use_classification_path_data.tsx
@@ -14,8 +14,8 @@ import {
   isClassificationFeatureImportanceBaseline,
   isRegressionFeatureImportanceBaseline,
   TopClasses,
-} from '../../../../../common/types/feature_importance';
-import { ExtendedFeatureImportance } from './decision_path_popover';
+} from '../../../../../../../common/types/feature_importance';
+import type { ExtendedFeatureImportance } from './decision_path_popover';
 
 export type DecisionPathPlotData = Array<[string, number, number]>;