Skip to content

Commit

Permalink
[npm] remove requirefrom package
Browse files Browse the repository at this point in the history
  • Loading branch information
spalger committed Feb 24, 2016
1 parent 4193985 commit 42f936e
Show file tree
Hide file tree
Showing 25 changed files with 28 additions and 59 deletions.
1 change: 0 additions & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -127,7 +127,6 @@
"moment-timezone": "0.4.1",
"raw-loader": "0.5.1",
"request": "2.61.0",
"requirefrom": "0.2.0",
"rimraf": "2.4.3",
"rjs-repack-loader": "1.0.6",
"script-loader": "0.6.1",
Expand Down
3 changes: 1 addition & 2 deletions src/cli/cli.js
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
import _ from 'lodash';

let utils = require('requirefrom')('src/utils');
let pkg = utils('packageJson');
import pkg from '../utils/packageJson';
import Command from './Command';

let argv = process.env.kbnWorkerArgv ? JSON.parse(process.env.kbnWorkerArgv) : process.argv.slice();
Expand Down
3 changes: 1 addition & 2 deletions src/cli/cluster/cluster_manager.js
Original file line number Diff line number Diff line change
Expand Up @@ -83,8 +83,7 @@ module.exports = class ClusterManager {

setupWatching(extraPaths) {
const chokidar = require('chokidar');
const utils = require('requirefrom')('src/utils');
const fromRoot = utils('fromRoot');
const fromRoot = require('../../utils/fromRoot');

this.watcher = chokidar.watch([
'src/plugins',
Expand Down
3 changes: 1 addition & 2 deletions src/cli/plugin/__tests__/setting_parser.js
Original file line number Diff line number Diff line change
@@ -1,8 +1,7 @@
import path from 'path';
import expect from 'expect.js';

var utils = require('requirefrom')('src/utils');
var fromRoot = utils('fromRoot');
import fromRoot from '../../../utils/fromRoot';
import settingParser from '../setting_parser';

describe('kibana cli', function () {
Expand Down
3 changes: 1 addition & 2 deletions src/cli/plugin/plugin.js
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
const utils = require('requirefrom')('src/utils');
const fromRoot = utils('fromRoot');
import fromRoot from '../../utils/fromRoot';
import settingParser from './setting_parser';
import installer from './plugin_installer';
import remover from './plugin_remover';
Expand Down
3 changes: 1 addition & 2 deletions src/cli/plugin/plugin_installer.js
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
import _ from 'lodash';
const utils = require('requirefrom')('src/utils');
const fromRoot = utils('fromRoot');
import fromRoot from '../../utils/fromRoot';
import pluginDownloader from './plugin_downloader';
import pluginCleaner from './plugin_cleaner';
import pluginExtractor from './plugin_extractor';
Expand Down
4 changes: 1 addition & 3 deletions src/cli/serve/read_yaml_config.js
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,7 @@ import _ from 'lodash';
import fs from 'fs';
import yaml from 'js-yaml';

let utils = require('requirefrom')('src/utils');
let fromRoot = utils('fromRoot');
import fromRoot from '../../utils/fromRoot';

let legacySettingMap = {
// server
Expand Down Expand Up @@ -67,4 +66,3 @@ module.exports = function (path) {
apply(config, val, key);
}, {});
};

5 changes: 2 additions & 3 deletions src/cli/serve/serve.js
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,7 @@ const { isWorker } = require('cluster');
const { resolve } = require('path');

const cwd = process.cwd();
const src = require('requirefrom')('src');
const fromRoot = src('utils/fromRoot');
import fromRoot from '../../utils/fromRoot';

let canCluster;
try {
Expand Down Expand Up @@ -127,7 +126,7 @@ module.exports = function (program) {
}

let kbnServer = {};
const KbnServer = src('server/KbnServer');
const KbnServer = require('../../server/KbnServer');
try {
kbnServer = new KbnServer(settings);
await kbnServer.ready();
Expand Down
7 changes: 2 additions & 5 deletions src/optimize/lazy/optmzrRole.js
Original file line number Diff line number Diff line change
@@ -1,10 +1,8 @@
import LazyServer from './LazyServer';
import LazyOptimizer from './LazyOptimizer';
module.exports = async (kbnServer, kibanaHapiServer, config) => {

let src = require('requirefrom')('src');
let fromRoot = src('utils/fromRoot');
import fromRoot from '../../utils/fromRoot';

export default async (kbnServer, kibanaHapiServer, config) => {
let server = new LazyServer(
config.get('optimize.lazyHost'),
config.get('optimize.lazyPort'),
Expand All @@ -20,7 +18,6 @@ module.exports = async (kbnServer, kibanaHapiServer, config) => {
})
);


let ready = false;

let sendReady = () => {
Expand Down
3 changes: 1 addition & 2 deletions src/plugins/elasticsearch/lib/__tests__/is_upgradeable.js
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,7 @@ import expect from 'expect.js';
import sinon from 'sinon';

import isUpgradeable from '../is_upgradeable';
let utils = require('requirefrom')('src/utils');
let pkg = utils('packageJson');
import pkg from '../../../../utils/packageJson';
let version = pkg.version;

describe('plugins/elasticsearch', function () {
Expand Down
3 changes: 1 addition & 2 deletions src/plugins/elasticsearch/lib/__tests__/routes.js
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
import expect from 'expect.js';
import util from 'util';
const requireFromTest = require('requirefrom')('test');
const kbnTestServer = requireFromTest('utils/kbn_server');
import * as kbnTestServer from '../../../../../test/utils/kbn_server';

const format = util.format;

Expand Down
1 change: 0 additions & 1 deletion src/plugins/elasticsearch/lib/is_upgradeable.js
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
import semver from 'semver';
const utils = require('requirefrom')('src/utils');
const rcVersionRegex = /(\d+\.\d+\.\d+)\-rc(\d+)/i;

module.exports = function (server, doc) {
Expand Down
3 changes: 0 additions & 3 deletions src/plugins/elasticsearch/lib/upgrade_config.js
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,6 @@ import isUpgradeable from './is_upgradeable';
import _ from 'lodash';
import { format } from 'util';

const utils = require('requirefrom')('src/utils');

module.exports = function (server) {
const MAX_INTEGER = Math.pow(2, 53) - 1;

Expand Down Expand Up @@ -54,4 +52,3 @@ module.exports = function (server) {
});
};
};

6 changes: 2 additions & 4 deletions src/plugins/testsBundle/index.js
Original file line number Diff line number Diff line change
@@ -1,10 +1,8 @@
import { union } from 'lodash';
import findSourceFiles from './findSourceFiles';
module.exports = (kibana) => {

let utils = require('requirefrom')('src/utils');
let fromRoot = utils('fromRoot');
import fromRoot from '../../utils/fromRoot';

export default (kibana) => {
return new kibana.Plugin({
config: (Joi) => {
return Joi.object({
Expand Down
6 changes: 3 additions & 3 deletions src/server/KbnServer.js
Original file line number Diff line number Diff line change
@@ -1,10 +1,10 @@
import Hapi from 'hapi';
import { constant, once, compact, flatten } from 'lodash';
import { promisify, resolve, fromNode } from 'bluebird';
import fromRoot from '../utils/fromRoot';
import pkg from '../utils/packageJson';

let utils = require('requirefrom')('src/utils');
let rootDir = utils('fromRoot')('.');
let pkg = utils('packageJson');
let rootDir = fromRoot('.');

module.exports = class KbnServer {
constructor(settings) {
Expand Down
4 changes: 1 addition & 3 deletions src/server/__tests__/basePath.js
Original file line number Diff line number Diff line change
@@ -1,10 +1,8 @@
import { resolve } from 'path';
import { fromNode as fn } from 'bluebird';
import expect from 'expect.js';
import requirefrom from 'requirefrom';

const requireFromTest = requirefrom('test');
const kbnTestServer = requireFromTest('utils/kbn_server');
import * as kbnTestServer from '../../../test/utils/kbn_server';
const basePath = '/kibana';

describe('Server basePath config', function () {
Expand Down
2 changes: 1 addition & 1 deletion src/server/config/config.js
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ import Joi from 'joi';
import _ from 'lodash';
import override from './override';
import createDefaultSchema from './schema';
let pkg = require('requirefrom')('src/utils')('packageJson');
import pkg from '../../utils/packageJson';
import clone from './deepCloneWithBuffers';
import { zipObject } from 'lodash';

Expand Down
3 changes: 1 addition & 2 deletions src/server/config/schema.js
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,7 @@ import path from 'path';
import { get } from 'lodash';
import { randomBytes } from 'crypto';

let utils = require('requirefrom')('src/utils');
let fromRoot = utils('fromRoot');
import fromRoot from '../../utils/fromRoot';

module.exports = () => Joi.object({
pkg: Joi.object({
Expand Down
5 changes: 1 addition & 4 deletions src/server/http/__tests__/index.js
Original file line number Diff line number Diff line change
@@ -1,8 +1,5 @@
import expect from 'expect.js';
import requirefrom from 'requirefrom';

const requireFromTest = requirefrom('test');
const kbnTestServer = requireFromTest('utils/kbn_server');
import * as kbnTestServer from '../../../../test/utils/kbn_server';

describe('cookie validation', function () {
let kbnServer;
Expand Down
4 changes: 1 addition & 3 deletions src/server/http/__tests__/xsrf.js
Original file line number Diff line number Diff line change
@@ -1,9 +1,7 @@
import expect from 'expect.js';
import { fromNode as fn } from 'bluebird';
import { resolve } from 'path';

const requireFromTest = require('requirefrom')('test');
const kbnTestServer = requireFromTest('utils/kbn_server');
import * as kbnTestServer from '../../../../test/utils/kbn_server';

const nonDestructiveMethods = ['GET'];
const destructiveMethods = ['POST', 'PUT', 'DELETE'];
Expand Down
2 changes: 1 addition & 1 deletion src/server/plugins/PluginCollection.js
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
import PluginApi from './PluginApi';
import { inspect } from 'util';
import { get, indexBy } from 'lodash';
let Collection = require('requirefrom')('src')('utils/Collection');
import Collection from '../../utils/Collection';

let byIdCache = Symbol('byIdCache');
let pluginApis = Symbol('pluginApis');
Expand Down
2 changes: 1 addition & 1 deletion src/ui/ui_app_collection.js
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import _ from 'lodash';
import UiApp from './ui_app';
let Collection = require('requirefrom')('src')('utils/Collection');
import Collection from '../utils/Collection';

let byIdCache = Symbol('byId');

Expand Down
2 changes: 1 addition & 1 deletion tasks/config/babel.js
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
let { defaults } = require('lodash');
let babelOptions = require('requirefrom')('src')('optimize/babelOptions');
let babelOptions = require('../../src/optimize/babelOptions');

module.exports = {
build: {
Expand Down
2 changes: 1 addition & 1 deletion tasks/config/esvm.js
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ module.exports = function (grunt) {
var resolve = require('path').resolve;
var directory = resolve(__dirname, '../../esvm');
var dataDir = resolve(directory, 'data_dir');
var uiConfig = require('requirefrom')('test')('serverConfig');
var uiConfig = require('../../test/serverConfig');

return {
options: {
Expand Down
7 changes: 2 additions & 5 deletions test/utils/kbn_server.js
Original file line number Diff line number Diff line change
@@ -1,11 +1,8 @@
import { defaultsDeep, set } from 'lodash';
import requirefrom from 'requirefrom';
import { header as basicAuthHeader } from './base_auth';
import { kibanaUser, kibanaServer } from '../shield';

const src = requirefrom('src');
const KbnServer = src('server/KbnServer');
const fromRoot = src('utils/fromRoot');
import KbnServer from '../../src/server/KbnServer';
import fromRoot from '../../src/utils/fromRoot';

const SERVER_DEFAULTS = {
server: {
Expand Down

0 comments on commit 42f936e

Please sign in to comment.