address i81n feedback

elastic · Oct 31, 2019 · 4928bf6 · 4928bf6
1 parent 66442f3
commit 4928bf6
Show file tree

Hide file tree

Showing 3 changed files with 15 additions and 3 deletions.
diff --git a/...k/legacy/plugins/canvas/canvas_plugin_src/uis/arguments/axis_config/extended_template.tsx b/...k/legacy/plugins/canvas/canvas_plugin_src/uis/arguments/axis_config/extended_template.tsx
@@ -73,7 +73,7 @@ export class ExtendedTemplate extends PureComponent<Props> {
     if (isDisabled) {
       return (
         <EuiText color="subdued" size="xs">
-          <p>Swtich on to view axis settings</p>
+          <p>{strings.getDisabledText()}</p>
         </EuiText>
       );
     }

diff --git a/x-pack/legacy/plugins/canvas/canvas_plugin_src/uis/arguments/filter_group.js b/x-pack/legacy/plugins/canvas/canvas_plugin_src/uis/arguments/filter_group.js
@@ -61,13 +61,13 @@ const FilterGroupInput = ({ onValueChange, argValue, argId, filterGroups }) => {
         </EuiFlexItem>
         <EuiFlexItem grow={false} className="canvasSidebar__panel-noMinWidth">
           <EuiButton type="submit" size="s" onClick={handleAddGroup}>
-            Set
+            {strings.getButtonSet()}
           </EuiButton>
         </EuiFlexItem>
       </EuiFlexGroup>
       <EuiSpacer size="s" />
       <EuiButtonEmpty color="danger" size="xs" onClick={() => setAddMode(!addMode)} flush="left">
-        Cancel
+        {strings.getButtonCancel()}
       </EuiButtonEmpty>
     </form>
   );

diff --git a/x-pack/legacy/plugins/canvas/i18n/ui.ts b/x-pack/legacy/plugins/canvas/i18n/ui.ts
@@ -35,6 +35,10 @@ export const ArgumentStrings = {
       i18n.translate('xpack.canvas.uis.arguments.axisConfigLabel', {
         defaultMessage: 'Visualization axis configuration',
       }),
+    getDisabledText: () =>
+      i18n.translate('xpack.canvas.uis.arguments.axisConfigDisabledText', {
+        defaultMessage: 'Switch on to view axis settings',
+      }),
     getPositionBottom: () =>
       i18n.translate('xpack.canvas.uis.arguments.axisConfig.position.options.bottomDropDown', {
         defaultMessage: 'bottom',
@@ -124,6 +128,14 @@ export const ArgumentStrings = {
       i18n.translate('xpack.canvas.uis.arguments.filterGroup.createNewGroupLinkText', {
         defaultMessage: 'Create new group',
       }),
+    getButtonSet: () =>
+      i18n.translate('xpack.canvas.uis.arguments.filterGroup.setValue', {
+        defaultMessage: 'Set',
+      }),
+    getButtonCancel: () =>
+      i18n.translate('xpack.canvas.uis.arguments.filterGroup.cancelValue', {
+        defaultMessage: 'Cancel',
+      }),
     getDisplayName: () =>
       i18n.translate('xpack.canvas.uis.arguments.filterGroupTitle', {
         defaultMessage: 'Filter Group',