Skip to content

Commit

Permalink
Update README
Browse files Browse the repository at this point in the history
  • Loading branch information
maryia-lapata committed Mar 11, 2020
1 parent 74ee0bc commit 4fc604f
Showing 1 changed file with 1 addition and 2 deletions.
3 changes: 1 addition & 2 deletions x-pack/plugins/graph/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ Graph shows only up in the side bar if your server is running on a platinum or t

* Run tests `node x-pack/scripts/jest.js --watch plugins/graph`
* Run type check `node scripts/type_check.js --project=x-pack/tsconfig.json`
* Run linter `node scripts/eslint.js x-pack/legacy/plugins/graph`
* Run linter `node scripts/eslint.js x-pack/plugins/graph`
* Run functional tests (make sure to stop dev server)
* Server `cd x-pack && node ./scripts/functional_tests_server.js`
* Tests `cd x-pack && node ../scripts/functional_test_runner.js --config ./test/functional/config.js --grep=graph`
Expand All @@ -21,7 +21,6 @@ Currently most of the state handling is done by a central angular controller. Th

* `angular/` contains all code using javascript and angular. Rewriting this code in typescript and react is currently ongoing. When the migration is finished, this folder will go away
* `components/` contains react components for various parts of the interface. Components can hold local UI state (e.g. current form data), everything else should be passed in from the caller. Styles should reside in a component-specific stylesheet
* `hacks/` contains files that need to run before the actual app is started. When moving to the new platform, this folder will go away.
* `services/` contains functions that encapsule other parts of Kibana. Stateful dependencies are passed in from the outside. Components should not rely on services directly but have callbacks passed in. Once the migration to redux/saga is complete, only sagas will use services.
* `helpers/` contains side effect free helper functions that can be imported and used from components and services
* `state_management/` contains reducers, action creators, selectors and sagas. It also exports the central store creator
Expand Down

0 comments on commit 4fc604f

Please sign in to comment.